Make clock options display better with dark theme

[LaurenWags]

Description

Follow up from #9038

When you open the Clock section on Customize Dashboard using dark theme, the text in the drop down (before expanding) is difficult to read. It might be better if this text was white instead of a medium gray color to offer better contrast.

Note, once you expand the drop down it's light (doesn't match the dark theme) so it's easier to read. Logged theme mismatch with #12060

Steps to Reproduce

1. Be using dark theme
2. On NTP open Customize Dashboard settings
3. Click on Clock

Actual result:

text on drop down (before expanding) is a bit dark IMO

Expected result:

tweak text on drop down so it offers better contrast for easier reading

Reproduces how often:

Brave version (brave://version info)

Brave	1.16.57 Chromium: 86.0.4240.75 (Official Build) dev (x86_64)
Revision	c69c33933bfc72a159aceb4aeca939eb0087416c-refs/branch-heads/4240@{#1149}
OS	macOS Version 10.14.6 (Build 18G3020)

Version/Channel Information:

• Can you reproduce this issue with the current release? n/a
• Can you reproduce this issue with the beta channel? yes, 1.16.x
• Can you reproduce this issue with the nightly channel? yes, 1.17.x

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? n/a
• Does the issue resolve itself when disabling Brave Rewards? n/a
• Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:

cc @bsclifton @rebron

[LaurenWags]

This might be fixed if #12060 is addressed, not sure so logged separately.

[rebron]

I'm seeing these as white on on 1.17.73, not medium gray.

[rebron]

screenshot above is darker than actual for some reason but it's the same color across all the different labels.

[mayralgr]

@rebron is this issue good to take? I would like to work on it. Also, this issue is independent to #12060

[LaurenWags]

@rebron just to clarify, I meant the wording inside the Format box that says Automatic (en-US), that seems dark to me and a little difficult to read.

[bsclifton]

@mayralgr absolutely - all yours 😄 Let us know if you need any help

[mayralgr]

I had some trouble running the project locally, if I solve it I'll get back to it. For now I left it open in case anyone wants to work on it.

[BrennenC]

I was wondering if anyone was actively working on this issue. If not, could I be assigned to it? It would be my first issue here.

[mayralgr]

@BrennenC I don't think anyone is working in this issue, I will suggest you to install the project and make a pr

[faraz16iqbal]

Hey is this issue still open?

[bsclifton]

Hi folks - yup; issue is open, feel free to grab it 😄 Once you get past the local setup, it shouldn't be too hard

[imashish1705]

hey, this issue still open?
I want to contribute

[Warkanlock]

Setting up the local env, if everything goes well I'll work on this! 💇‍♂️

[imashish1705]

Cloning into 'brave-browser'... git@github.com: Permission denied (publickey). fatal: Could not read from remote repository. Please make sure you have the correct access rights and the repository exist This message show so can you help me! how i fix this error

…

On Sat, Mar 6, 2021 at 8:54 PM Ignacio Brasca ***@***.***> wrote: Setting up the local env, if everything goes well I'll work on this! :D — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#12061 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ALL7QTI3V36D2FX2GC7FD63TCJCMVANCNFSM4SKABGHA> .

[Warkanlock]

I spot the issue but it's not related with brave-browser ui itself. In order to fix this here we would have to use some hacky thing, although this it's related with brave-ui component (Select component, precisely) so would be nice to modify this from the source library

Should I make a PR to brave-ui instead? @bsclifton

Edit: I solve this in a PR using theme as reference for styling in the component. Work so far on my env. I'm now working in order to make a PR

[Warkanlock]

Just in case I left here the PR associated with this issue on brave-core

brave/brave-core#8172

[Warkanlock]

Did anyone review the PR yet? @LaurenWags @bsclifton

[LaurenWags]

@Warkanlock I don't believe so, I've requested a review from @bsclifton on brave/brave-core#8172 since he can provide guidance in this area. Thanks!

[bsclifton]

Oh shoot - sorry about that @Warkanlock - will try to review ASAP. Thanks for your patience! 😄

[Warkanlock]

No worries 💯

[shubhamkapoor01]

I'm new to open source, I'll give this one a shot today!

[nullhook]

@shubhamkapoor01 There's a PR for this already.

[coder-abdo]

is this issue still open?

[KSSaiTeja]

i am interested to contribute this, please assign me this

[Rakshit358]

Is this still open? Would like to contribute to it.

[BearerOP]

Is this issue still open to contribute ? Willing to contribute to it.