Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Widget] Confirmation countdown stops when network is lost #12733

Closed
srirambv opened this issue Nov 17, 2020 · 1 comment · Fixed by brave/brave-core#7178
Closed

[Widget] Confirmation countdown stops when network is lost #12733

srirambv opened this issue Nov 17, 2020 · 1 comment · Fixed by brave/brave-core#7178
Labels
bug feature/widgets OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release/blocking release-notes/exclude

Comments

@srirambv
Copy link
Contributor

srirambv commented Nov 17, 2020

Description

Confirmation countdown stops when network is lost

Steps to reproduce

  1. Connect to Binance widget
  2. Select a token to convert
  3. Enter amount and preview conversion
  4. Disconnect network and tap on confirm button, count down stops

Actual result

Confirmation countdown stops when network is lost

Expected result

Countdown should complete and dismiss or close the preview confirmation message

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.19.12 x64 nightly build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

@srirambv
Copy link
Contributor Author

srirambv commented Nov 19, 2020

Verification passed on OnePlus 6T with Android 10 running 1.17.71 x64 RC build

  • Verified confirmation countdown doesn't stop when network is lost
  • Verified preview conversion is dismissed when countdown completes irrespective of network state
  • Verified check your network connection message is shown when tapped on confirm button when network is lost and also dismisses the preview conversion view

Verification passed on Samsung Tab A with Android 10 running 1.17.71 x64 RC build

  • Verified confirmation countdown doesn't stop when network is lost
  • Verified preview conversion is dismissed when countdown completes irrespective of network state
  • Verified check your network connection message is shown when tapped on confirm button when network is lost and also dismisses the preview conversion view

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/widgets OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release/blocking release-notes/exclude
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant