Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix format error in Brave Stats #12831

Closed
deeppandya opened this issue Nov 21, 2020 · 1 comment · Fixed by brave/brave-core#7225
Closed

Fix format error in Brave Stats #12831

deeppandya opened this issue Nov 21, 2020 · 1 comment · Fixed by brave/brave-core#7225
Assignees
Labels
OS/Android Fixes related to Android browser functionality QA/No release-notes/include

Comments

@deeppandya
Copy link

Description

We have an issue with format in brave stats and this issue should address it.

Actual result

Screenshot_20201120-225157_copy_1080x1351

Expected result

Should show correct values

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version: Release

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@kjozwiak
Copy link
Member

Removed QA/Yes and added QA/No after speaking with @deeppandya. Looks like we need ~1-2GB of Saved Data for the issue to reproduce which is very difficult to get manually. @deeppandya confirmed that the fix worked after manually editing the values on a local build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
OS/Android Fixes related to Android browser functionality QA/No release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants