Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix release version issues android (uplift to 1.18.x) #7226

Merged
merged 1 commit into from
Nov 25, 2020
Merged

Fix release version issues android (uplift to 1.18.x) #7226

merged 1 commit into from
Nov 25, 2020

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented Nov 21, 2020 •
edited by kjozwiak
Loading

Uplift of #7225
Resolves brave/brave-browser#12831
Resolves brave/brave-browser#12834

Approved, please ensure that before merging:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.
  • You have tested your change on Nightly.
  • The PR milestones match the branch they are landing to.

After you merge:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team November 21, 2020 21:23
@brave-builds brave-builds self-assigned this Nov 21, 2020
@brave-builds brave-builds added this to the 1.18.x - Beta milestone Nov 21, 2020
kjozwiak
kjozwiak approved these changes Nov 25, 2020
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.18.x approved after deliberating with @brave/uplift-approvers.

@kjozwiak kjozwiak merged commit 8fff78a into 1.18.x Nov 25, 2020
@mihaiplesa mihaiplesa deleted the pr7225_fix_release_version_issues_android_1.18.x branch November 25, 2020 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.18.x - Release
3 participants
@brave-builds @kjozwiak @brave-browser-releases