Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support IPFS gateway method first on Android #13683

Closed
bbondy opened this issue Jan 20, 2021 · 3 comments · Fixed by brave/brave-core#8257 or brave/brave-core#8302
Closed

Support IPFS gateway method first on Android #13683

bbondy opened this issue Jan 20, 2021 · 3 comments · Fixed by brave/brave-core#8257 or brave/brave-core#8302
Labels
feature/web3/ipfs OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects

Comments

@bbondy
Copy link
Member

bbondy commented Jan 20, 2021

Let's add support for IPFS via gateway to Android.

We would show this page on the first IPFS load:
#13655

But without the local node option to start.

@bbondy bbondy added this to Untriaged in IPFS via automation Jan 20, 2021
@bbondy bbondy moved this from Untriaged to Backlog in IPFS Jan 20, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 20, 2021
@lidel
Copy link

lidel commented Jan 20, 2021

👍 (cc @autonome)
Ubiquitous support for resolution of ipfs:// and ipns:// URIs (even if its only via a customizable gateway) is very important for us

@bbondy bbondy added OS/Android Fixes related to Android browser functionality and removed OS/Desktop labels Jan 20, 2021
@bbondy bbondy moved this from Backlog to In Progress in IPFS Mar 15, 2021
IPFS automation moved this from In Progress to Done Mar 18, 2021
@bbondy bbondy added this to the 1.24.x - Nightly milestone Mar 18, 2021
@bbondy bbondy reopened this Mar 18, 2021
@bbondy
Copy link
Member Author

bbondy commented Mar 18, 2021

Re-opening because of a warning causing an error on Android. I'll fix then re-land.

@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 29, 2021
@stephendonner
Copy link

stephendonner commented Apr 29, 2021

Verified PASSED using Brave 1.24.76, Chromium 90.0.4430.85 on Android 9, Google Pixel XL, arm64.

Steps:

  1. new profile/install
  2. loaded ipns://brantly.eth
  3. confirmed I got the interstitial page
  4. tapped on Use public gateway
  5. confirmed the page loaded after a brief DNS lookup (and error page, expected for now - we've fixed that on desktop, I believe)
  6. new profile/install (again)
  7. load ipfs://bafybeiemxf5abjwjbikoz4mc3a3dla6ual3jsgpdr4cjr3oz3evfyavhwq/wiki/Vincent_van_Gogh.html
  8. tapped on Use public gateway
  9. confirmed the page loaded after a brief DNS lookup (and error page, expected for now - we've fixed that on desktop, I believe)
example example example example
Screenshot_20210429-110859 Screenshot_20210429-110908 Screenshot_20210429-112800 Screenshot_20210429-112810

Verification passed on Samsung Tab A with Android 10 running 1.24.81 x64 build

  • Verified when a ipns:// or ipfs:// URI is loaded shows the interstitial page
  • Verified using public gateway loads the page correctly using public gateway
  • Verified when IPFS public gateway setting is disabled in setting, page fails to load
Interstitial Page ipns:// Error page when public gateway disabled
image image image
Interstitial Page ipfs:// Error page when public gateway disabled
image image image

@stephendonner stephendonner added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/web3/ipfs OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
IPFS
  
Done
4 participants