Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-land android IPFS gateway support #8302

Merged
merged 2 commits into from
Mar 19, 2021
Merged

Re-land android IPFS gateway support #8302

merged 2 commits into from
Mar 19, 2021

Conversation

bbondy
Copy link
Member

@bbondy bbondy commented Mar 19, 2021

Resolves brave/brave-browser#13683

Reland #8257 with the warning mentioned in #8299 fixed

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@bbondy bbondy requested review from bridiver and a team as code owners March 19, 2021 00:29
@bbondy bbondy self-assigned this Mar 19, 2021
Copy link
Member

@SergeyZhukovsky SergeyZhukovsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

++

@bbondy bbondy merged commit dd13dc5 into master Mar 19, 2021
@bbondy bbondy deleted the ipfs-android-2 branch March 19, 2021 13:49
@bbondy bbondy added this to the 1.24.x - Nightly milestone Mar 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants