New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Block Scripts and Fingerprinting Protection not working when open a guest/tor window multiple times #1381
Comments
STR:
Shields stop working correctly for scripts and fingerprinting protection (ads/trackers still work, I didn't test others) after we open a guest / tor window for the second time. |
BraveContentSettingsObserver::IsBraveShieldsDown return true when this bug happens, that's why script blocking and fingerprinting protection settings has no effect because it thinks shields is down. |
@yrliou #1381 (comment) is similar to #1437? |
We lost those brave default rules (especially the braveShields one) which only be set once when init HostContentSettingsMap, I think this issue will also be resolved by brave/brave-core#622. |
Test Plan:
|
Verification Passed on
Verification Passed on
Verified passed with
*Verified test plan from #1381 (comment) |
Test plan
See #1381 (comment)
POC: http://peltate-worth.000webhostapp.com/world.html
Version:
0.55.10 Chromium: 70.0.3538.22 (Official Build) beta (64-bit)
The text was updated successfully, but these errors were encountered: