Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hardcode blocking PDFJS telemetry #1388

Closed
bbondy opened this issue Oct 2, 2018 · 1 comment · Fixed by brave/brave-core#596
Closed

Hardcode blocking PDFJS telemetry #1388

bbondy opened this issue Oct 2, 2018 · 1 comment · Fixed by brave/brave-core#596
Labels
QA/No
Milestone
0.55.x - Release ...

Comments

@bbondy
Copy link
Member

bbondy commented Oct 2, 2018

Find a better solution for PDFJS since the current one could have a race condition:

Currently we disable via ad-block list, but I think it's possible for the ad-block list to be not ready yet when PDFJS is first installed.

! Disable PDFJS which we include by default's telemetry
||pdfjs.robwu.nl
@bbondy bbondy modified the milestone: 1.x Backlog Oct 2, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, Releasable builds 0.55.x Oct 10, 2018
bbondy added a commit to brave/brave-core that referenced this issue Oct 10, 2018
@bbondy
Hardcode PDF.js telemetry disabling
6a35e4a 
Fix brave/brave-browser#1388
bbondy added a commit to brave/brave-core that referenced this issue Oct 10, 2018
@bbondy
Hardcode PDF.js telemetry disabling
33e1bd9 
Fix brave/brave-browser#1388
bbondy added a commit to brave/brave-core that referenced this issue Oct 10, 2018
@bbondy
Hardcode PDF.js telemetry disabling
8aafb3a 
Fix brave/brave-browser#1388
@bbondy bbondy added the QA/No label Oct 10, 2018
bbondy added a commit to brave/brave-core that referenced this issue Oct 10, 2018
@bbondy
Hardcode PDF.js telemetry disabling
0598a53 
Fix brave/brave-browser#1388
bbondy added a commit to brave/brave-core that referenced this issue Oct 10, 2018
@bbondy
Hardcode PDF.js telemetry disabling
423932d 
Fix brave/brave-browser#1388
bbondy added a commit to brave/brave-core that referenced this issue Oct 10, 2018
@bbondy
Hardcode PDF.js telemetry disabling
4cadca1 
Fix brave/brave-browser#1388
@bbondy bbondy mentioned this issue Oct 10, 2018
Merged
18 tasks
@bbondy
Copy link
Member Author

bbondy commented Oct 12, 2018

FYI @diracdeltas

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
QA/No
Projects
None yet
Milestone
0.55.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Use component updater for installing PDF.js brave/brave-core
1 participant
@bbondy