Enhance Tor process cleanup with __OwningControllerProcess and TAKEOWNERSHIP

[darkdh]

We currently rely on cleaning orphaned Tor process by pidFile when launching the new Tor process

And we can prevent orphaned Tor process by launching Tor with option __OwningControllerProcess plus utility process pid and when control connection established send TAKEOWNERSHIP so no matter how we crash Brave browser process or kill utility process, there shouldn't be any orphaned Tor process left
https://github.com/torproject/torspec/blob/d3a4dadac149c2be162344a6c2286653b8ac3753/control-spec.txt#L1525

[stephendonner]

Verified FIXED using nightly build

Brave	1.23.23 Chromium: 89.0.4389.72 (Official Build) nightly (x86_64)
Revision	3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS	macOS Version 11.2.3 (Build 20D91)

Verified both test cases from the plan in brave/brave-core#7927:

Case 1: Browser process crashed

1. Open Tor window
2. Make sure tor-* process is running, the process name is platform dependent.
3. In normal window, type chrome://inducebrowsercrashforrealz/ in URL bar
4. Browser should crash and tor-* process should no longer exist

screencast

Case 2: Kill Tor launcher utility process

1. Open Tor window
2. Make sure tor-* process is running, the process name is platform dependent and remember its pid
3. Open Task Manager in Brave
4. Kill Tor Launcher
5. A new tor-* process should be spawned which should have different pid than step 2
6. Enter https://brave5t5rjjg3s6k.onion/ in URL bar
7. The onion site should be loaded normally
8. Close Tor window and tor-* process should no longer exist

screencast

---

Verification passed on

Brave | 1.23.56 Chromium: 89.0.4389.105 (Official Build) dev (64-bit)
-- | --
Revision | 14f44e21a9d539cd49c72468a29bfca4fa43f710-refs/branch-heads/4389_90@{#7}
OS | Windows 10 OS Version 2004 (Build 19041.867)

• Verified the test plan from Tor control refactor brave-core#7927

Case 1: Browser process crashed

• Opened a TOR window and ensured TOR launcher process is running

• In normal window, type chrome://inducebrowsercrashforrealz/ in URL bar and ensured brave crashes, relaunched browser and ensured TOR process isn't running
  

Case 2: Kill Tor launcher utility process

• Opened a TOR window and noted TOR process PID 25552
  

• End the TOR process via Task manager and ensured new PID 1432 is listed for TOR process
  

• Opened https://brave5t5rjjg3s6k.onion/ and ensured onion site loads successfully
  

• Closed TOR window and ensured TOR process isn't running

---

Verified passed with

Brave	1.23.63 Chromium: 89.0.4389.114 (Official Build) beta (64-bit)
Revision	1ea76e193b4fadb723bfea2a19a66c93a1bc0ca6-refs/branch-heads/4389@{#1616}
OS	Linux

Verified test plan from brave/brave-core#7927

Scenario 1 - Browser process crashed

1. Open Tor window
2. Make sure tor-* process is running, the process name is platform dependent.

3. In normal window, type chrome://inducebrowsercrashforrealz/ in URL bar
4. Browser should crash and tor-* process should no longer exist

Scenario 2 - Kill Tor launcher utility process

1. Open Tor window
2. Make sure tor-* process is running, the process name is platform dependent and remember its pid

3. Open Task Manager in Brave

4. Kill Tor Launcher
5. A new tor-* process should be spawned which should have different pid than step 2

Example	Example

6. Enter https://brave5t5rjjg3s6k.onion/ in URL bar
7. Confirmed the onion site should be loaded normally
8. Closed Tor window and confirmed tor-* process does not show in Brave or System Task Managers

[stephendonner]

Hi @darkdh - do you think this should be tested on all supported desktop platforms? If so, we can add the QA/Test-all-platforms tag; thanks!

[darkdh]

yep, we should test it on all desktop platforms