Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Update icons in the main menu #14109

Closed
samartnik opened this issue Feb 11, 2021 · 9 comments · Fixed by brave/brave-core#8002 or brave/brave-core#8007
Closed

[Android] Update icons in the main menu #14109

samartnik opened this issue Feb 11, 2021 · 9 comments · Fixed by brave/brave-core#8002 or brave/brave-core#8007

Comments

@samartnik
Copy link
Contributor

samartnik commented Feb 11, 2021

Description

We need updated menu icons in the main menu.
device-2021-02-11-121944

Expected result

image
#14113

Assets

Figma: https://www.figma.com/file/PqLTp3DnANLQMM1XzaChqZ/?node-id=0%3A1

@samartnik samartnik added QA/Yes release-notes/exclude OS/Android Fixes related to Android browser functionality labels Feb 11, 2021
@samartnik samartnik added this to Backlog in Android General via automation Feb 11, 2021
@samartnik
Copy link
Contributor Author

cc @jamesmudgett

@samartnik samartnik self-assigned this Feb 18, 2021
@samartnik
Copy link
Contributor Author

@karenkliu we have 2 more items when page is loaded Find in page and Add to Home screen. Not sure if we want new icons for them.

device-2021-02-18-141811

@samartnik
Copy link
Contributor Author

Test plan:

  1. Enable Android tabbed app overflow menu icons in brave://flags (not required on cr90 and later).
  2. Make sure that icons match expected result from the first post.

Android General automation moved this from Backlog to Done/Closed Feb 19, 2021
@samartnik samartnik added this to the 1.22.x - Nightly milestone Feb 19, 2021
@karenkliu
Copy link

@deeppandya Can you use these two icons for "Find in page" and "Add to home screen"?

image

@samartnik
Copy link
Contributor Author

I'll update these 2

@samartnik samartnik reopened this Feb 19, 2021
Android General automation moved this from Done/Closed to In Progress Feb 19, 2021
@deeppandya
Copy link

Thanks @samartnik for updating it.

@rodrigoswz
Copy link

Just a detail, if enable brave://flags/#tabbed-app-overflow-menu-regroup the Downloads and Bookmarks icons are no longer the new ones added.

Screenshot_20210219-125144.png

@samartnik
Copy link
Contributor Author

Thank you for pointing out @rodrigoswz

@srirambv
Copy link
Contributor

srirambv commented Mar 9, 2021

Verification passed on Samsung Tab A with Android 10 running 1.22.54 x64 beta build

New Tab On Page Tab Tray
image image image

Verification passed on OnePlus 6T with Android 10 running 1.22.54 x64 beta build

Bottom bar enabled

New Tab On Page Tab Tray
image image image

Bottom bar disabled

New Tab On Page Tab Tray
image image image

Logged #14588 as a follow up suggestion

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment