Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set "rewards enabled" pref when the user opts-in to Rewards #14414

Closed
zenparsing opened this issue Mar 1, 2021 · 1 comment · Fixed by brave/brave-core#8273
Closed

Set "rewards enabled" pref when the user opts-in to Rewards #14414

zenparsing opened this issue Mar 1, 2021 · 1 comment · Fixed by brave/brave-core#8273
Assignees
@zenparsing
Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
Brave Rewards
Milestone
1.24.x - Release

Comments

@zenparsing
Copy link

We currently do not set the "brave.rewards.enabled" pref when the user opts-in to Rewards. Instead, we set more granular flags and rely on those values. For future flexibility, we should go back to using this flag to record the opt-in state of the user.
@zenparsing zenparsing self-assigned this Mar 1, 2021
@zenparsing zenparsing added this to New Issues in Brave Rewards via automation Mar 1, 2021
@stephendonner
Copy link

Thanks for filing, @zenparsing; is this partly what's going on in #14413?

@zenparsing zenparsing moved this from New Issues to In progress in Brave Rewards Mar 3, 2021
@zenparsing zenparsing moved this from In progress to Backlog in Brave Rewards Mar 10, 2021
@zenparsing zenparsing moved this from Backlog to In progress in Brave Rewards Mar 16, 2021
@zenparsing zenparsing mentioned this issue Mar 16, 2021
Merged
24 tasks
Brave Rewards automation moved this from In progress to Done Apr 2, 2021
@zenparsing zenparsing added this to the 1.24.x - Nightly milestone Apr 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zenparsing zenparsing

Labels
feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
Brave Rewards
  
Done
Milestone
1.24.x - Release
Development

Successfully merging a pull request may close this issue.

Use rewards enabled pref to track opt-in status brave/brave-core
2 participants
@stephendonner @zenparsing