"Include in Auto-Contribute" pref not working for Greaselion-enabled publishers

[stephendonner]

Description

"Include in Auto-Contribute" pref auto-toggles to OFF after first flipping OFF to ON, then dismissing panel.

Steps to Reproduce

1. new profile, launch Brave with --args --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=6,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=5
2. click "Skip welcome tour"
3. click "Start using Rewards"
4. click "Claim my Rewards"
5. pass the reCaptcha challenge
6. load https://twitter.com/bravelaurenwags
7. click on the BAT icon in the URL bar
8. notice that "Include in Auto-Contribute" is toggled ON
9. toggle it from ON to OFF
10. dismiss the Rewards panel
11. click on the BAT icon in the URL bar again
12. now click to toggle from OFF to ON, dismiss the panel
13. reopen the panel now, and notice that "Include in Auto-Contribute" self-toggles to OFF

Actual result:

"Include in Auto-Contribute" auto-toggles back to OFF, and the following exception is dumped in the console:

[19807:775:0301/110936.784322:WARNING:CONSOLE(1)] "Received external message from a sender who is not allowed to send messages to this background. Origin: chrome-extension://jidkidbbcafjabdphckchenhfomhnfma, URL: chrome-extension://jidkidbbcafjabdphckchenhfomhnfma/brave_rewards_panel.html", source: chrome-extension://mnojpmjdmbbfmejpflffifhffcmidifd/out/brave_extension_background.bundle.js (1)

Expected result:

"Include in Auto-Contribute" should be ON, as the ON/OFF preference for "Include in Auto-Contribute" should persist between panel openings/closings.

Reproduces how often:

100%

Brave version (brave://version info)

Brave	1.21.70 Chromium: 89.0.4389.69 (Official Build) (x86_64)
Revision	6df9174a477a0bea2118cb4669954d517be16104-refs/branch-heads/4389@{#1332}
OS	macOS Version 11.2.2 (Build 20D80)

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes (1.20.110)
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

cc: @emerick @LaurenWags

[LaurenWags]

cc @zenparsing

[zenparsing]

Thanks @stephendonner for the very detailed description - will look into it!

[emerick]

@stephendonner I'm not able to repro on master. Are you still seeing this in the latest nightly? I think I followed your steps pretty exactly, but let me know!

[stephendonner]

@emerick yup, I can still reproduce this with

Brave	1.23.23 Chromium: 89.0.4389.72 (Official Build) nightly (x86_64)
Revision	3f345f156bfd157bd1bea06310e55f3fb2490359-refs/branch-heads/4389@{#1393}
OS	macOS Version 11.2.3 (Build 20D91)

But it's because I missed a step in the instructions (editing now for clarify; apologies!); when you first open the panel, you have to toggle it from ON -> OFF, then dismiss, then reopen the panel - the rest of the steps should be accurate, then.

[emerick]

@stephendonner Nice, I can repro following what you did in that GIF. Will investigate, thanks.

[emerick]

This is happening only for Greaselion-enabled publishers (e.g., Twitter, Github, Reddit, etc.) Updated the title to reflect that.

[stephendonner]

Verified PASSED using my original steps to reproduce, here, on nightly build

Brave	1.24.11 Chromium: 89.0.4389.90 (Official Build) nightly (x86_64)
Revision	62eb262cdaae9ef819aadd778193781455ec7a49-refs/branch-heads/4389@{#1534}
OS	macOS Version 11.2.3 (Build 20D91)

Verified that Rewards/ auto-contribute pref state persisted correctly between panel dismisses, and even new-tab page loads.

---

Verification passed on

Brave	1.24.66 Chromium: 90.0.4430.72 (Official Build) beta (64-bit)
Revision	b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS	Ubuntu 18.04 LTS

Verified test plan from the description. Verified test plan from brave/brave-core#8295
Verified that Rewards/ auto-contribute pref state persisted correctly between panel dismisses, and even new-tab page loads.

---

Verification passed on

Brave | 1.24.65 Chromium: 90.0.4430.72 (Official Build) dev (64-bit)
-- | --
Revision | b6172ef8d07ef486489a4b11b66b2eaeed50d132-refs/branch-heads/4430@{#1233}
OS | Windows 10 OS Version 2004 (Build 19041.928)

Verified test plan from the description. Verified test plan from brave/brave-core#8295
Verified that Rewards/ auto-contribute pref state persisted correctly between panel dismisses, and even new-tab page loads.