Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open in Browser causes shields to show up as disabled #14645

Closed
srirambv opened this issue Mar 11, 2021 · 1 comment · Fixed by brave/brave-core#8297
Closed

Open in Browser causes shields to show up as disabled #14645

srirambv opened this issue Mar 11, 2021 · 1 comment · Fixed by brave/brave-core#8297
Assignees
Labels
bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Open in Browser causes shields to show up as disabled

Steps to reproduce

  1. Install GPS build
  2. Open Slack and follow a link
  3. Select Brave from browser list
  4. Click on menu -> Open in Browser
  5. Page loads in browser but shields looks disabled but still clickable
  6. Reload page shows enabled mode

Actual result

Open in Browser causes shields to show up as disabled

Expected result

Should always show shields enabled if its enabled

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86):ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 10

Brave version

1.21.74

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @samartnik

@srirambv
Copy link
Contributor Author

Verification passed on OnePlus 6T with Android 10 running 1.22.65 x64 build

  • Verified steps from issue description
  • Verified disabling shields on custom tab doesn't enable it when switched to browser mode

Verification passed on Samsung Tab A with Android 10 running 1.22.65 x64 build

  • Verified steps from issue description
  • Verified disabling shields on custom tab doesn't enable it when switched to browser mode

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Yes regression release-notes/include
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.

4 participants