Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hide Brave Rewards icon in address bar #1475

Closed
Brave-Matt opened this issue Oct 10, 2018 · 70 comments

Comments

@Brave-Matt
Copy link
Collaborator

commented Oct 10, 2018

Description

I've had several users ask if there was a way for them to disable or hide the Brave Rewards icon in the URL bar:
image

Users should be able to disable or hide the icon if they're not interested in the program. Very minor/cosmetic but worth considering.

Steps to Reproduce

N/A

Brave version (chrome://version info)

Dev/Beta builds, v0.55.11 and up

Reproducible on current release:

N/A

Website problems only:

N/a

Additional Information

Two reports with a few users requesting this in each thread, have a couple Reddit posts to add as well then I find them:
https://community.brave.com/t/q-remove-brave-rewards/34515/7
(ignore thread title, request is in comments) https://community.brave.com/t/search-bar-by-address-bar/34388/14

@srirambv

This comment has been minimized.

Copy link
Collaborator

commented Oct 10, 2018

+1 on disabling BAT logo when user dismisses the first notification and until rewards is enabled.

@srirambv srirambv added this to the 1.x Backlog milestone Oct 10, 2018

@rebron rebron added the priority/P5 label Nov 2, 2018

@xv

This comment has been minimized.

Copy link

commented Dec 5, 2018

+1
I didn't uninstall Chrome only to find myself ending up with more crap I don't want.

@NejcZdovc NejcZdovc added this to Untriaged Backlog in Rewards via automation Dec 6, 2018

@NejcZdovc NejcZdovc moved this from Untriaged Backlog to Need investigation/Suggestions in Rewards Dec 6, 2018

@sobolevn

This comment has been minimized.

Copy link

commented Dec 6, 2018

There one more thing that bothers me.
This red intention-seeking notification that I can not switch off or accept.

2018-12-06 10 54 43

It would be awesome to switch these two icons off. Especially Rewards.

@snertev

This comment has been minimized.

Copy link

commented Dec 8, 2018

+1 to disable the whole extension as long as the user doesn't join the program.

It should be a default for each Brave extension that is not used.

@volcbs

This comment has been minimized.

Copy link

commented Dec 10, 2018

+1 too
I want to use Brave, but I really can't ignore the wallet icon that I don't want to use it at least right now.

@davidtemkin

This comment has been minimized.

Copy link
Collaborator

commented Dec 10, 2018

@sobolevn If you click to view the alert, once, the red dot will go away. It disappears as soon as you view the popup, regardless of whether your enable Brave Rewards.

@sobolevn

This comment has been minimized.

Copy link

commented Dec 10, 2018

@davidtemkin thanks for the suggestion! But, sadly it is not the case for me. That's a bug I guess.

@davidtemkin

This comment has been minimized.

Copy link
Collaborator

commented Dec 10, 2018

That is indeed a bug! Thank you @sobolevn , we will address.

@anonrig

This comment has been minimized.

Copy link

commented Dec 11, 2018

The main reason why I switched from Chrome to Brave is to get rid of shitty things like this triangle.

@eljuno

This comment has been minimized.

@SylentBobNJ

This comment has been minimized.

Copy link

commented Dec 20, 2018

+1 please remove this unneeded icon

@harrypnyce

This comment has been minimized.

Copy link

commented Dec 27, 2018

+1 +1 +1
Yes, please. Pretty, pretty please allow us to hide (or better yet remove) the "Brave Rewards" icon in the Brave Browser. Otherwise, almost zero complaints -- thrilled to have just made the transition from Google Chrome to Brave Browser. Only ~24 hours into the switch, but this is a major adjustment I'd been attempting (and failing) to make the switch for close to a calendar year now. FINALLY thinking I may be successful. I know this is the wrong place to heap praise upon Brave Browser, but i'm absolutely giddy with the initial results.

@Rundik

This comment has been minimized.

Copy link

commented Dec 28, 2018

+1

@Qix-

This comment has been minimized.

Copy link

commented Dec 28, 2018

Stop saying +1, it doesn't get it finished any faster. Use the emoji responses so everyone and their grandmother don't get notifications for it...

@harrypnyce

This comment has been minimized.

Copy link

commented Dec 29, 2018

Stop saying +1

Bigger, better, faster, more... Git`er done, fellas!~ Can't stop, won't stop.

@pedrogarcia

This comment has been minimized.

Copy link

commented Dec 30, 2018

Why do I have this stupid "Brave Rewards" icon in my browser?

It's like an horrible ad, that stays turned on and show a horrible notification in the address bar, and is tracking all the pages I visit, with no way to completely disable this horrible feature.

I do not want it, and I wish to remove it!

@maikeldotuk

This comment has been minimized.

Copy link

commented Dec 30, 2018

Any news on this? Is it going to be removed or should we remove brave browser altogether?

@Rundik

This comment has been minimized.

Copy link

commented Dec 30, 2018

I did it already

@maikeldotuk

This comment has been minimized.

Copy link

commented Dec 30, 2018

@gasman0015

This comment has been minimized.

Copy link

commented Jan 1, 2019

I will not use Brave until this obnoxious problem is fixed.

@maikeldotuk

This comment has been minimized.

Copy link

commented Jan 1, 2019

@tomlowenthal

This comment has been minimized.

Copy link
Member

commented Feb 4, 2019

When Rewards isn't enabled, it doesn't do anything. It's disabled! Again: Brave Rewards is already disabled when not in use. Rewards is only enabled when you affirmatively click a button or flip a switch. You have to turn it on before it does anything.

Right now, the icon is visible whether or not Rewards is enabled. This issue is about hiding the icon when rewards isn't enabled. This is a cosmetic issue — hiding the icon. It doesn't change Brave Rewards' fundamental behavior, which is that Rewards doesn't do anything unless you deliberately enable it.

There isn't any need for another issue about disabling Brave Rewards, because that's already how Brave Rewards works. It's fully disabled unless you decide to turn it on.

@gabrielhug

This comment has been minimized.

Copy link

commented Feb 4, 2019

The browser Task Manager (Shift-Esc) shows the Brave Rewards extension maintaining a separate Process ID and memory footprint of about 20MB even when not in use. Although I understand it doesn't do anything unless configured, it is not currently possible to disable the built-in extension itself. Some (including #2789 and #2966) have asked about removing/disabling this perceived "bloat". I think these relate more directly with #1104 and should not have been merged here.

@davidtemkin

This comment has been minimized.

Copy link
Collaborator

commented Feb 4, 2019

Thanks, helpful @gabrielhug . That's an interesting piece of information. That said, much of Brave Rewards is not packaged as an extension; the code is in the core browser -- but should be completely inactive when Rewards isn't on.

@NejcZdovc NejcZdovc moved this from In Progress to Pending review in Rewards Feb 5, 2019

@rebron rebron modified the milestone: 1.x Backlog Feb 7, 2019

@NejcZdovc NejcZdovc moved this from Pending review to Completed in Rewards Feb 12, 2019

@NejcZdovc NejcZdovc added this to the 0.61.x - Beta milestone Feb 19, 2019

@S0ulan

This comment has been minimized.

Copy link

commented Feb 20, 2019

Any news on getting rid of the icon?

@tomlowenthal

This comment has been minimized.

Copy link
Member

commented Feb 20, 2019

This change to hide the icon was in brave/brave-core@76d0644, which is currently in beta. If you're using beta or dev builds of Brave, you should see a setting to hide the Rewards icon.

screen shot 2019-02-20 at 11 31 05 am

@btlechowski

This comment has been minimized.

Copy link
Collaborator

commented Feb 26, 2019

Handled in #2975. The fix is part of current Beta (0.61.x).

@rebron rebron moved this from In progress to Completed in Front End Feb 26, 2019

@beyera

This comment has been minimized.

Copy link

commented Mar 1, 2019

Thanks! Just started using Brave today and was about to uninstall until I found out this was in the beta. ❤️

@Rundik

This comment has been minimized.

Copy link

commented Mar 1, 2019

If I understood it right they say you can't remove this thing at all, you can only hide it. Even in chrome you can decide which extensions to have, but not in brave

@bsclifton

This comment has been minimized.

Copy link
Member

commented Mar 1, 2019

@Rundik that's correct for the time being - we do have a task captured to terminate the process when disabled: #3436

@iZero7

This comment has been minimized.

Copy link

commented Mar 10, 2019

anyone knows how to build brave from source without brave rewards?

also thanks for deleting my comment, i get it,bye

@Rundik

This comment has been minimized.

Copy link

commented Mar 10, 2019

The idea to build brave from source without brave rewards is kind of interesting

@gabrielhug

This comment has been minimized.

Copy link

commented Mar 11, 2019

The issue created for disabling the rewards extension entirely rather than just hiding the icon is: #3436
I'd suggest at least giving it a thumbs-up if it matters to you. It'd likely be helpful to carry on related conversation there rather than here on this closed issue.

@simonhong

This comment has been minimized.

Copy link
Collaborator

commented Mar 11, 2019

@iZero7

anyone knows how to build brave from source without brave rewards?

I think brave rewards would be disabled by modifying brave/components/brave_rewards/browser/buildflags/buildflags.gni like below.

diff --git a/components/brave_rewards/browser/buildflags/buildflags.gni b/components/brave_rewards/browser/buildflags/buildflags.gni
index 79b648e89..8eec046d2 100644
--- a/components/brave_rewards/browser/buildflags/buildflags.gni
+++ b/components/brave_rewards/browser/buildflags/buildflags.gni
@@ -1,5 +1,5 @@
 import("//build/config/features.gni")

 declare_args() {
-  brave_rewards_enabled = is_mac || is_linux || is_win || is_android
+  brave_rewards_enabled = false
 }

or in brave-browser,

diff --git a/lib/config.js b/lib/config.js
index 1983da7..4487120 100644
--- a/lib/config.js
+++ b/lib/config.js
@@ -91,7 +91,8 @@ Config.prototype.buildArgs = function () {
     chrome_version_major: chrome_version_parts[0],
     safebrowsing_api_endpoint: this.safeBrowsingApiEndpoint,
     brave_referrals_api_key: this.braveReferralsApiKey,
-    enable_hangout_services_extension: this.enable_hangout_services_extension
+    enable_hangout_services_extension: this.enable_hangout_services_extension,
+    brave_rewards_enabled = false
   }

   if (process.platform === 'darwin') {

@rebron rebron removed this from Completed in Front End Mar 13, 2019

@rebron rebron removed this from Completed in Rewards Mar 13, 2019

@pvlg

This comment has been minimized.

Copy link

commented Apr 16, 2019

Another attempt to start using brave browser failed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.