Option to hide Brave Shields activity count

[innergy]

Test plan

See brave/brave-core#3150

Description

Some people think the incrementing block count on Brave Shields is distracting.

The color of the icon is enough for me to know whether it's enabled or not, and if it's enabled I trust that it's working. I'm happy to click the icon if I need more details, but that's rare.

Provide the option to hide the block count while still keeping the shields up.

Designs

Add "Indicate the number of blocked items on the Shields icon" to Shields settings:

It will be toggled ON by default. If the user toggles the indicator OFF, the Shields icon will not have the incrementing blocked item counter, but will still be colored when it's enabled.

[cndouglas]

This feature used to be available with Brave Muon: brave/browser-laptop#8613, brave/browser-laptop#8701

Label: browser-laptop-parity

[muellerberndt]

+1.

The count being displayed is horrible for somebody with OCD tendencies (like me). It constantly makes me feel like there are some open notifications I'm supposed to handle 😞

[ghost]

+1 - please devs, give us an option to hide that counter and a seperate option to hide the lion icon. It's useless for me, and IMHO not aesthetic all in all. Less is more.

[english06]

+1

[hucknz]

+1

[vladk]

+1 all popular ad blockers have option to hide blocked items counter, that's very surprising brave browser doesn't have that. that counter is super distracting, so actually brave browser isn't usable for me while there is no option to hide it

[colonicregulator]

+1 all popular ad blockers have option to hide blocked items counter, that's very surprising brave browser doesn't have that. that counter is super distracting, so actually brave browser isn't usable for me while there is no option to hide it

Echo this. Completely unusable without this option. Back to Firefox for time being.

[karenkliu]

Designs added @tomlowenthal

[caroltoo]

Can I ask what P3 backlog means in terms of timelines? This is incredibly distracting to me too and I would love to know if this is going to be updated soon after I just migrated everything from Chrome.

[bsclifton]

@caroltoo hard to estimate a timeline, but this issue is definitely on our radar and we do want to fix it 😄 I don't think it would be a terribly difficult change to make (we'd just need to set aside the time to do it)

[Brave-Matt]

+1 from Reddit:
https://www.reddit.com/r/brave_browser/comments/bjdk7d/how_to_turn_off_the_number_of_ads_blocked_on/

[usaccounts]

Time to fork guys.

[igekaratas]

Hi, how do I put this setting into my Brave browser? I am not good with Github, I don't know how to apply these kind of settings.
Thanks.

[bsclifton]

@igekaratas thanks for your patience; we're reviewing now and should be able to merge a fix for this soon 😄

[GeetaSarvadnya]

Verification passed on

Brave	1.7.67 Chromium: 80.0.3987.149 (Official Build) beta (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Windows 10 OS Version 1803 (Build 17134.1006)

• Verified the test plan from [brave-extension] add settings option to hide Shields activity count brave-core#3150
• Verified Show the number of blocked items on the Shields icon works as expected when toggling OFF/ON
• Verified that changes are reflected across all the tabs in Normal Tab/Private Tab/Private tab with Tor
• Verified in both clean and upgraded profiles
  

Verification passed on

Brave	1.7.71 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
Revision	5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS	Ubuntu 18.04 LTS

• Verified the test plan from [brave-extension] add settings option to hide Shields activity count brave-core#3150
• Verified Show the number of blocked items on the Shields icon works as expected when toggling OFF/ON
• Verified that changes are reflected across all the tabs in Normal Tab/Private Tab/Private tab with Tor
• Verified in both clean and upgraded profiles

Verification PASSED on macOS 10.15.3 x64 Catalina using the following build:

Brave | 1.7.79 Chromium: 80.0.3987.149 (Official Build) dev (64-bit)
-- | --
Revision | 5f4eb224680e5d7dca88504586e9fd951840cac6-refs/branch-heads/3987_137@{#16}
OS | macOS Version 10.15.3 (Build 19D76)

• verified the STR/Cases outlined via [brave-extension] add settings option to hide Shields activity count brave-core#3150 (comment)
• ensured that Show the number of blocked items on the Shields icon is enabled by default
• ensured that disabling Show the number of blocked items on the Shields icon affects currently opened tabs + newly created tabs
• ensured that disabling/enabling Show the number of blocked items on the Shields icon doesn't affect current shield settings
• ensured that the Show the number of blocked items on the Shields icon setting is remembered when restarting the browser
• ensured the feature works under PB and Tor windows
• ensured that upgrading from 1.5.115 CR: 80.0.3987.149 worked as expected

[usaccounts]

Brave is now usable. Switched.