Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Toned down interstitials for top-level blocking #15189

Closed
fmarier opened this issue Apr 8, 2021 · 11 comments
Closed

Toned down interstitials for top-level blocking #15189

fmarier opened this issue Apr 8, 2021 · 11 comments
Labels
closed/not-actionable l10n needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy

Comments

@fmarier
Copy link
Member

fmarier commented Apr 8, 2021

Description

Ignoring list errors, there are currently three classes of resources that will be blocked using the Top Level Blocking feature (Search for Top Level Blocking feature spec on GDrive):

  1. email trackers with server-side redirections
  2. cookie syncing redirect chains
  3. bad sites (e.g. typo squatters)

The V1 UX works well for the third category since we don't want/expect users to ignore our warning and click through to the tracking site.

In the case of the first one however, we expect a high click-through rate because of the implicit intent to visit the destination site (on the other side of the tracker). The risk with warning for this class of trackers is that it will train users to ignore all interstitial warning pages, most of which can lead to very serious harm (e.g. a phishing page blocked by Safe Browsing):

Screenshot from 2021-04-07 18-57-58

@pes10k tells me that he is less concerned about the third class of sites and that we should optimize the warning interstitials in V2 of the top-level blocking for the first two classes.

Designs

Existing

Screenshot from 2021-04-12 20-02-52

Revised

image

Assets

Figma: https://www.figma.com/file/aJu3WGDztEWNZgwQTD9yx2/?node-id=0%3A1

Use Brave's shared checkbox and button component.

@fmarier fmarier added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 8, 2021
@fmarier
Copy link
Member Author

fmarier commented Apr 9, 2021

@karenkliu recommended the following UI treatment:

  • White background
  • Info icon

as per the redesigned error pages on brave/brave-ios#483.

I also brought up https://testsafebrowsing.appspot.com/s/trick_to_bill.html and we agreed that it should have a red background instead to align its severity with the other Safe Browsing pages.

@fmarier
Copy link
Member Author

fmarier commented Apr 9, 2021

Here's an idea for the revised copy:

The page ahead may attempt to track you across sites

This page may be trying to link some of your personal data with a cookie before taking you to your intended destination. You can choose to allow this potential privacy leak and proceed to the next page, or you can block this tracking attempt by going back to the previous page.

@bridiver
Copy link
Contributor

The current "Suspicious site ahead" seems overly ominous sounding for a tracking click-through and #15189 (comment) seems better to me

@fmarier fmarier removed the design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. label Apr 13, 2021
@pes10k
Copy link
Contributor

pes10k commented Apr 13, 2021

Just wanted to say that this all looks terrific, thanks everyone in the issue for working on this!

@pes10k pes10k added privacy privacy-pod Feature work for the Privacy & Web Compatibility pod privacy/feature User-facing privacy- & security-focused feature work. labels Apr 13, 2021
@bsclifton
Copy link
Member

@fmarier is the spec'd design (above) a modal? or would this new UI be displayed in a tab (like it is now)… just with updated copy/styling?

@fmarier
Copy link
Member Author

fmarier commented Apr 14, 2021

@bsclifton The new UI would be displayed exactly like it is right now (e.g. visit https://adcash.com/ to see one), just with updated copy & styling.

@rebron rebron added l10n needs-text-change This change requires some careful wording. labels Apr 20, 2021
@mkarolin mkarolin self-assigned this Apr 21, 2021
mkarolin added a commit to brave/brave-core that referenced this issue Apr 22, 2021
Also, switched to Chromium's information (i) icon instead of the red
exclamation point.

Partially fixes brave/brave-browser#15189

Note: this commit doesn't make any styling modifications outlined in the
above issue.
@mkarolin mkarolin removed their assignment May 18, 2021
@rebron rebron added this to P1 & P2 backlog in Front End Aug 3, 2021
@pes10k
Copy link
Contributor

pes10k commented Sep 7, 2021

@fmarier @pilgrim-brave can this be closed now?

@karenkliu
Copy link

The new UI hasn't been done for Android/Desktop yet, so I don't think this can be closed yet.

@fmarier fmarier removed the privacy-pod Feature work for the Privacy & Web Compatibility pod label Oct 27, 2023
@fmarier
Copy link
Member Author

fmarier commented Nov 28, 2023

The Android interstitial for this is currently broken (showing the desktop one by the looks of it):
Screenshot (28 nov  2023 11 h 32 min 40 s)

@ShivanKaul
Copy link
Collaborator

The Desktop version OTOH looks LGTM.

image

@ShivanKaul
Copy link
Collaborator

I think the UI for Desktop looks good. I opened #34573 to track Android design updates for this. Closing this one.

@rebron rebron moved this from P1 & P2 backlog to Completed in Front End Dec 5, 2023
@rebron rebron removed this from Completed in Front End Dec 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
closed/not-actionable l10n needs-text-change This change requires some careful wording. OS/Android Fixes related to Android browser functionality OS/Desktop privacy/feature User-facing privacy- & security-focused feature work. privacy
Development

No branches or pull requests

8 participants