Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Group-tabs toolbar missing when bottom toolbar is disabled #15642

Closed
stephendonner opened this issue May 5, 2021 · 1 comment · Fixed by brave/brave-core#8721
Closed

Group-tabs toolbar missing when bottom toolbar is disabled #15642

stephendonner opened this issue May 5, 2021 · 1 comment · Fixed by brave/brave-core#8721

Comments

@stephendonner
Copy link

Description

Group-tabs toolbar missing when bottom toolbar is disabled

Steps to reproduce

  1. clean profile, launch Brave
  2. open two sites in separate tabs
  3. open Settings > Appearance and set Enable Tab Groups to On
  4. toggle Enable bottom toolbar to Off
  5. tap on the "three dots" menu on the toolbar and select Group tabs
  6. select the two tabs, then tap Group
  7. after the tabs are grouped, tap on a tab
  8. note the tab count to the right of the BAT icon
  9. also note there's no group-tabs control on the bottom

Actual result

We're missing the group-tabs control on the bottom

example example
Screenshot_20210505-121431 Screenshot_20210505-121443

Expected result

With the bottom toolbar disabled, we still should see the group-tab control at the bottom

Screenshot_20210505-123600

It should look like the below screenshot, but without the very bottom toolbar (which, when disabled, yields this bug!)

Issue reproduces how often

100%

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): arm64
  • Device type (Phone, Tablet, Phablet): Google Pixel XL
  • Android version: 9.0

Brave version

1.24.82, Chromium 90.0.4430.93

@srirambv
Copy link
Contributor

Verification passed on OnePlus 6T with Android 10 running 1.24.84 x64 build

  • Verified disabling bottom toolbar still shows tab groups bar at the bottom of the browser
  • Verified able to switch between tabs in group via swipe on the URL bar
  • Verified able to switch between regular tab and tab group via swipe on the URL bar
  • Verified works on both normal and private tabs

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment