Cr91 follow-up: Fix omnibox selection color. #15690
Assignees
Milestone
Comments
mkarolin
added a commit
to brave/brave-core
that referenced
this issue
May 7, 2021
Fixes brave/brave-browser#15690 Due to the cr91 upstream change below the omnibox selection color is now the same color as the focus ring of the omnibox. Since we override the focus ring to be our brand color, the selection is now also the brand color, which we don't want. This fix reverts the omnibox selection color to what it was in cr90 (kGoogleBlue200 for Light theme, kGoogleBlue800 for Dark). Chromium changes: This change redefined kColorId_TextfieldSelectionBackgroundFocused from explicit colors (gfx::kGoogleBlue200 and gfx::kGoogleBlue800 ) to fall back onto kColorId_LabelTextSelectionBackgroundFocused. https://source.chromium.org/chromium/chromium/src/+/76f9ef872febca7e3630db31c699ad2c2ec4e7a5 commit 76f9ef872febca7e3630db31c699ad2c2ec4e7a5 Author: Peter Kasting <pkasting@chromium.org> Date: Mon Feb 22 17:56:22 2021 +0000 Convert existing color definitions to more canonical forms. This defines as many colors as possible in terms of a small number of core colors. The primary benefit of this is to remove most dark mode color definitions (which will now be automatically correct). It also makes some relationships clearer. No behavior change intended (yet). Bug: none This change made kColorId_LabelTextSelectionBackgroundFocused fall back to AlphaBlend(kColorId_ProminentButtonColor, kColorId_WindowBackground, gfx::kGoogleGreyAlpha500) We redefine kColorId_ProminentButtonColor as kBraveColorBrand = RGB(0xfb, 0x54, 0x2b). https://source.chromium.org/chromium/chromium/src/+/c042fff0a7823aa4ebb0494d5b094f67f15aa4b3 commit c042fff0a7823aa4ebb0494d5b094f67f15aa4b3 Author: Peter Kasting <pkasting@chromium.org> Date: Wed Mar 24 21:10:08 2021 +0000 Tweak existing systematized colors. Primarily, this adjusts menus, tables, trees, and textfields to all use the same blue to represent a selected item (and that blue now matches the focus ring). Bug: 1061127
This was referenced May 7, 2021
|
Verified
Steps:
Confirmed text-selection color is blue in both
|
|
This will be uplifted into |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This issue is for Windows and Linux only.
Due to cr91 upstream change https://source.chromium.org/chromium/chromium/src/+/c042fff0a7823aa4ebb0494d5b094f67f15aa4b3 the omnibox selection color is now the same color as the focus ring of the omnibox. Since we override the focus ring to be our brand color, the selection is now also the brand color, which we don't want.
Revert the omnibox selection color to what it was in cr90.
STR:
QA: Please, test both Light and Dark modes.
The text was updated successfully, but these errors were encountered: