Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove IPFS button on built-in ipfs-webui #15718

Closed
Tracked by #17112
lidel opened this issue May 10, 2021 · 3 comments · Fixed by brave/brave-core#8980
Closed
Tracked by #17112

Remove IPFS button on built-in ipfs-webui #15718

lidel opened this issue May 10, 2021 · 3 comments · Fixed by brave/brave-core#8980

Comments

@lidel
Copy link

lidel commented May 10, 2021

Brave 1.26.7 displays "Open using IPFS" badge when /webui is opened via the API port:

2021-05-10--18-11-54

This introduces confusing behavior, because when the user clicks on the badge, the same CID is loaded from the Gateway port, which has different Origin than the API port, which in turn asks user to safelist new Origin by setting CORS headers on their go-ipfs node.

I believe the better UX is if the badge is not be displayed when the URL comes from the same origin as API port exposed by go-ipfs.

@lidel
Copy link
Author

lidel commented May 27, 2021

FYSA in addition to the UX problem described above, this is also impacted by the bug described in #16115

@spylogsster I still think the best course of action here is to now show badge on URLs coming from the API port.

@spylogsster spylogsster moved this from Untriaged to In Progress in IPFS Jun 1, 2021
@spylogsster spylogsster self-assigned this Jun 1, 2021
@spylogsster spylogsster moved this from In Progress to In Review in IPFS Jun 1, 2021
IPFS automation moved this from In Review to Done Jun 2, 2021
@spylogsster spylogsster added this to the 1.27.x - Nightly milestone Jun 2, 2021
@stephendonner
Copy link

Verified FIXED using the testplan from brave/brave-core#8980 with build

Brave 1.27.37 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.5 (Build 20G5023d)

Steps:

  1. clean profile
  2. launched Brave
  3. loaded ipns://brantly.eth
  4. clicked on Use a local node
  5. waited for configuration to finish
  6. loaded brave://ipfs-internals/
  7. clicked on My Node
  8. confirmed on the resulting http://127.0.0.1:45002/ipfs/bafybeianwe4vy7sprht5sm3hshvxjeqhwcmvbzq73u55sdhqngmohkjgs4/#/ page:
  • no Open using IPFS badge in the URL bar
  • no context-menu option to import the page to IPFS

Screen Shot 2021-06-02 at 7 40 35 PM

@rebron rebron changed the title IPFS badge on built-in ipfs-webui Remove IPFS button on built-in ipfs-webui Jul 23, 2021
@vampyren
Copy link

How do you uninstall the ipfs?
I accidentally clicked on it next to the badge and suddenly it was running and asking to get added in firewall. I have disabled it from settings but how can it be uninstalled? i don't want a service i dont.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment