Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: "Open using IPFS" badge broken on local gateway URLs #16115

Closed
Tracked by #17112
lidel opened this issue May 27, 2021 · 3 comments · Fixed by brave/brave-core#8971
Closed
Tracked by #17112

Bug: "Open using IPFS" badge broken on local gateway URLs #16115

lidel opened this issue May 27, 2021 · 3 comments · Fixed by brave/brave-core#8971

Comments

@lidel
Copy link

lidel commented May 27, 2021

(found in nightly-1.27.25-linux-amd64)

Opening a path gateways URL like https://ipfs.io/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR or http://127.0.0.1:48080/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR and clicking on the "Open using IPFS" badge produces an error because duplicated (invalid) path is used in the request:

2021-05-28--01-35-27

2021-05-28--01-33-22

@spylogsster an example of path gateways is ipfs.io or 127.0.0.1.
(Subdomain gateways like dweb.link and localhost seem to work fine)

@stephendonner
Copy link

stephendonner commented Jun 9, 2021

@spylogsster current behavior on nightly is for

http://127.0.0.1:48081/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR (or http://127.0.0.1:48080/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR) and https://ipfs.io/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR to not show the Open using IPFS badge; should they?

http://127.0.0.1:48081/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR https://ipfs.io/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR
Screen Shot 2021-06-09 at 10 10 42 AM Screen Shot 2021-06-09 at 10 12 55 AM

If so, we should file a separate bug, right?

@spylogsster
Copy link

@stephendonner added #16339

@stephendonner
Copy link

Verified PASSED using the testplan at brave/brave-core#8971 with build

Brave 1.27.62 Chromium: 91.0.4472.101 (Official Build) nightly (x86_64)
Revision af52a90bf87030dd1523486a1cd3ae25c5d76c9b-refs/branch-heads/4472@{#1462}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. new profile
  2. loaded ipns://brantly.eth
  3. clicked on Use a local node
  4. loaded https://ipfs.io/ipfs/QmbWqxBEKC3P8tqsKc98xmWNzrzDtRLMiMPL8wBuTGsMnR
  5. clicked on the Open using IPFS badge in the URL bar
  6. confirmed it opened ipfs://bafybeigdyrzt5sfp7udm7hu76uh7y26nf3efuylqabf3oclgtqy55fbzdi/ which did not have another Open using IPFS badge
example example
Screen Shot 2021-06-14 at 11 34 47 AM Screen Shot 2021-06-14 at 11 34 52 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment