Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not launch node if it is not used #16085

Closed
spylogsster opened this issue May 26, 2021 · 1 comment · Fixed by brave/brave-core#8931
Closed

Do not launch node if it is not used #16085

spylogsster opened this issue May 26, 2021 · 1 comment · Fixed by brave/brave-core#8931

Comments

@spylogsster
Copy link

Description

Broken here brave/brave-core#8892

Node started automatically even if the ipfs method is set as Ask

Steps to Reproduce

Just start the browser

Actual result:

Expected result:

node doesnt start if it is not used

Reproduces how often:

easy

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@stephendonner
Copy link

stephendonner commented May 28, 2021

Verified PASSED using the testplan from brave/brave-core#8931 with build

Brave 1.27.25 Chromium: 91.0.4472.77 (Official Build) nightly (x86_64)
Revision 1cecd5c8a856bc2a5adda436e7b84d8d21b339b6-refs/branch-heads/4472@{#1246}
OS macOS Version 11.4 (Build 20F71)

Steps:

  1. clean profile
  2. started Brave and confirmed the IPFS node is not launched automatically
  3. shut down
  4. relaunched Brave, this time using --enable-logging=stderr --vmodule="*/bat-native-ledger/*"=6,"*/brave_rewards/*"=6,"*/bat-native-ads/*"=6,"*/bat-native-confirmations/*"=6,"*/brave_ads/*"=9,"*/brave_user_model/*"=6 --brave-ads-staging --brave-ads-debug --rewards=staging=true,reconcile-interval=5 --use-dev-goupdater-url
  5. confirmed that it got an update to 0.9.0-rc1 from the development server
example example example
Screen Shot 2021-05-27 at 5 21 31 PM Screen Shot 2021-05-27 at 5 22 50 PM Screen Shot 2021-05-27 at 5 26 12 PM

Console:

generating ED25519 keypair...done
peer identity: 12D3KooWGqKHNn8SjbquyonRefSUGDNj67F1ZkJ7AGCRLkQXmXVp
initializing IPFS node at /Users/stephendonner/Library/Application Support/BraveSoftware/Brave-Browser-Nightly/brave_ipfs
to get started, enter:

	ipfs cat /ipfs/QmQPeNsJPyVWPFDVHb77w8G42Fvo15z4bG2X8D2GhfbSXc/readme

Error: daemon not running
Initializing daemon...
go-ipfs version: 0.9.0-rc1
Repo version: 11
System version: amd64/darwin
Golang version: go1.16.4
Swarm listening on /ip4/10.0.0.5/tcp/44002
Swarm listening on /ip4/127.0.0.1/tcp/44002
Swarm listening on /ip6/::1/tcp/44002
Swarm listening on /p2p-circuit
Swarm announcing /ip4/10.0.0.5/tcp/44002
Swarm announcing /ip4/127.0.0.1/tcp/44002
Swarm announcing /ip6/::1/tcp/44002
API server listening on /ip4/127.0.0.1/tcp/45002
WebUI: http://127.0.0.1:45002/webui
Gateway (readonly) server listening on /ip4/127.0.0.1/tcp/48081
Daemon is ready

Verification passed on


Brave | 1.27.78 Chromium: 91.0.4472.114 (Official Build) beta (64-bit)
-- | --
Revision | 4bb19460e8d88c3446b360b0df8fd991fee49c0b-refs/branch-heads/4472@{#1496}
OS | Windows 10 OS Version 2004 (Build 19041.1052)

example example example
image image image

Logs from console:

generating ED25519 keypair...done
peer identity: 12D3KooWEyLfviDpy3jCv1Kwws8pfMHgDcAGi5CvRaVGa2BLq5dW
initializing IPFS node at C:\Users\DELL\AppData\Local\BraveSoftware\Brave-Browser-Beta\User Data\brave_ipfs
to get started, enter:

        ipfs cat /ipfs/QmQPeNsJPyVWPFDVHb77w8G42Fvo15z4bG2X8D2GhfbSXc/readme

Error: daemon not running
Initializing daemon...
go-ipfs version: 0.9.0
Repo version: 11
System version: amd64/windows
Golang version: go1.16.5
Swarm listening on /ip4/127.0.0.1/tcp/44004
Swarm listening on /ip4/169.254.111.239/tcp/44004
Swarm listening on /ip4/169.254.15.6/tcp/44004
Swarm listening on /ip4/169.254.200.245/tcp/44004
Swarm listening on /ip4/169.254.231.68/tcp/44004
Swarm listening on /ip4/169.254.254.216/tcp/44004
Swarm listening on /ip4/169.254.30.193/tcp/44004
Swarm listening on /ip4/169.254.33.234/tcp/44004
Swarm listening on /ip4/169.254.6.225/tcp/44004
Swarm listening on /ip4/169.254.84.243/tcp/44004
Swarm listening on /ip4/192.168.1.2/tcp/44004
Swarm listening on /ip6/::1/tcp/44004
Swarm listening on /p2p-circuit
Swarm announcing /ip4/127.0.0.1/tcp/44004
Swarm announcing /ip4/192.168.1.2/tcp/44004
Swarm announcing /ip6/::1/tcp/44004
API server listening on /ip4/127.0.0.1/tcp/45004
WebUI: http://127.0.0.1:45004/webui
Gateway (readonly) server listening on /ip4/127.0.0.1/tcp/48083
Daemon is ready

Verified PASSED using the testplan from brave/brave-core#8931 with build

Brave	1.27.91 Chromium: 91.0.4472.124 (Official Build) beta (64-bit)
Revision	7345a6d1bfcaff81162a957e9b7d52649fe2ac38-refs/branch-heads/4472_114@{#6}
OS	Linux
example example example
Screen Shot 2021-07-06 at 2 43 08 PM Screen Shot 2021-07-06 at 2 53 03 PM Screen Shot 2021-07-06 at 2 58 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment