Remove "Gmail" language in SafeBrowsing text

[Miyayes]

Description

Currently, some "Gmail" language appears in the browser.

Solution

Remove "Gmail" language in the Brave browser.

Reports

https://www.reddit.com/r/brave_browser/comments/nq2w0i/what_i_didnt_know_that_gmail_was_a_brave_service/

[srirambv]

This is an issue on Android as well

[Areckleh]

Reports through Brave Support Twitter DMs

[rebron]

#11345 I think this is only Android and not on Desktop.

[akshat-rawat]

Hi, I would like to work on this issue.
I have tracked down the root of this issue at brave-core/app/settings_strings.grdp, brave-core/browser/ui/android/strings/android_chrome_strings.grd and in .xtb files.

[srirambv]

@akshat-rawat Assigned the issue to you. Please open a PR for it.

[akshat-rawat]

@srirambv, Thankyou for the opportunity, I just wanted to confirm the changes.
From.
Does not protect you against dangerous websites, downloads and extensions. You’ll still get Safe Browsing protection, where available, in other Brave services, like Gmail and Search.
To,
Does not protect you against dangerous websites, downloads and extensions.

Or is there a better alternative?

[srirambv]

Looping in @fmarier @karenkliu for text change. We may want to keep the You'll still get Safe Browsing protection part

[akshat-rawat]

What about?
Does not protect you against dangerous websites, downloads and extensions. You’ll still get Safe Browsing protection, where available, in other Brave services, like Search and Passwords.

[karenkliu]

cc @rmcfadden3 on this for the text change. We have an in-house copywriter now and should filter all our text through them.

[akshat-rawat]

@karenkliu, please let me know if there are any updates on what the changed text should be.

[rmcfadden3]

How about this:

Does not protect you against dangerous websites, downloads, or extensions. (Where available, you’ll still get safe browsing protection in other Brave services.)

[srirambv]

@rmcfadden3 We proxy safe browsing requests so we may want to somehow mention that in there. Someone from @brave/sec-team may pitch in on it.

[soham4abc]

I am working on this issue. making the message " Does not protect you against dangerous websites, downloads, and extensions. (Where available, you’ll still get safe browsing protection in other Brave services.)"

@srirambv is it okay?

[srirambv]

@soham4abc Think @akshat-rawat may already have a PR ready for it. You can always choose any issues from here.

As for the wording I'd wait till someone from security team responds and @rmcfadden3 can update accordingly which can be used.

[soham4abc]

@soham4abc Think @akshat-rawat may already have a PR ready for it. You can always choose any issues from here.

As for the wording I'd wait till someone from security team responds and @rmcfadden3 can update accordingly which can be used.

Okay then I am making a PR. If the wording needs to be changed I will do so.
If possible please do assign me for this issue!
Thank you!

[soham4abc]

@soham4abc Think @akshat-rawat may already have a PR ready for it. You can always choose any issues from here.

As for the wording I'd wait till someone from security team responds and @rmcfadden3 can update accordingly which can be used.

Okay sure! I already made a PR and if required will close it if @akshat-rawat has the PR I will close my PR later.

[akshat-rawat]

@soham4abc I do have a PR ready just wanted to confirm the changed text.

[soham4abc]

@soham4abc I do have a PR ready just wanted to confirm the changed text.

Sure... My PR is closed! Go ahead!

[akshat-rawat]

Is "Does not protect you against dangerous websites, downloads, or extensions. (Where available, you’ll still get safe browsing protection in other Brave services.)"
final or are we still waiting, @srirambv?

[srirambv]

We should wait on #16181 (comment)

[fmarier]

Given that we don't run GMail and Google Search, I think we should simply drop the second sentence and just have:

Does not protect you against dangerous websites, downloads, or extensions.

That's why it's not recommended. You're turning off all of the Google Safe Browsing protections if you choose that option.

[akshat-rawat]

Should i move forward with Does not protect you against dangerous websites, downloads, or extensions.?

[srirambv]

@akshat-rawat yes please. Go ahead and create the PR

[akshat-rawat]

@srirambv, I have created the PR.
If there are any updates required, do let me know.

[bsclifton]

Removing assignment as above PR was closed

[srirambv]

Verification passed on the following devices running 1.28.99 64 Beta build

• Verified references to Brave is removed from safe browsing settings

Oppo R5 (Android 11)	Samsung Tab A (Android 10)