the No Internet screen shows the Chrome logo when you die in the dinosaur game

[thepwrtank18]

Description

If you go to chrome://dino, press spacebar, and die in the dinosaur game, you get Chrome branding. See the actual result image.

Steps to Reproduce

1. Visit chrome://dino (or turn your internet off and try to visit any site)
2. Press the spacebar
3. Die in the dinosaur game

Actual result:

It goes back to this screen after 1 second, like in Chrome:

Expected result:

Should just show just the last screen, or the Brave logo.

Reproduces how often:

Every time

Brave version (brave://version info)

• Brave: 1.26.77 Chromium: 91.0.4472.164 (Official Build) (64-bit)
• Revision: 541163496c9982c98f61819bab7cf2183ea8180f-refs/branch-heads/4472@{Upload non-generated strings to Transifex too #1569} (not a pr, but ok)
• OS according to Brave: Windows 10 OS Version 2009 (Build 22000.100)
• Actual OS: Windows 11 Insider Preview, build 22000.100

Version/Channel Information:

• Can you reproduce this issue with the current release? Yes
• Can you reproduce this issue with the beta channel? Yes
• Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

• Does the issue resolve itself when disabling Brave Shields? No
• Does the issue resolve itself when disabling Brave Rewards? No
• Is the issue reproducible on the latest version of Chrome? Yes, as it's Chrome branding

[bsclifton]

@Ayushsunny when you do a full clone of brave-browser and run npm run init, you can find the image file under src/components/neterror/resources/images/

We can potentially add a chromium_src patch for this. In the brave-core repo, this would be a file under chromium_src folder with the same path / file name as the original. For example, a new file could be added components/neterror/resources/images/default_100_percent/offline/100-offline-sprite.png that's edited to put the Brave icon

Here's a link to the files in Chromium Code Search

• https://source.chromium.org/chromium/chromium/src/+/main:components/neterror/resources/images/default_100_percent/offline/100-offline-sprite.png
• https://source.chromium.org/chromium/chromium/src/+/main:components/neterror/resources/images/default_200_percent/offline/200-offline-sprite.png

[ishan1880]

I would like to work on this issue. Please assign me this one.

[AnudeepGunukula]

Hi @bsclifton i would like to work on this issue. kindly assign it to me
i will make a pr as soon as possible.

[moiz-lakkadkutta]

is this issue still open?

[thepwrtank18]

It is still an issue.

…

On Sat, Sep 4, 2021 at 11:59 AM moiz-lakkadkutta ***@***.***> wrote: is this issue still open? — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#17124 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ANXJY7H4C5LMF4QPHEIUVZ3UAI65LANCNFSM5A3LALQA> .

-- Why does avast always embed their stupid ad into my emails

[chinmaym07]

Can I work on this issue ?

[bsclifton]

@chinmaym07 sure - it's all yours. No need to have the issue formally assigned 😄 Just follow up here once you have something or if you have questions

[EnzoItaliano]

@bsclifton hello, I worked on this issue but I don't know how to make my commit, can you help me?

I did the change in the folder components/neterror/resources/images/default_100_percent/offline/ but it doesn't exists in this repository and I could not find it at brave-core repository to make a commit normally.

[EnzoItaliano]

@bsclifton I made the edited version of 100-offline-sprite.png and put into the folder src/brave/chromium_src/components/neterror/resources/images/default_100_percent/offline and the same to the 200-offline-sprite. The problem is that it is not working but it is what is writen here #17124 (comment), right?
Before I was putting the images I made inside the folder src/components/neterror/resources/images/default_100_percent/offline and doing this, it works

[bsclifton]

@EnzoItaliano sorry for the long time it's taken to respond here

What you attempted looks good and it should work - let me check with the team here

[bsclifton]

@EnzoItaliano definitely my mistake here; chromium_src only overrides on source files (ex: .h, .cc, .mm files)

You can look at putting the image in our directory structure under components/neterror/resources/images/default_100_percent/offline (it can be the only file there, that should be fine)

Then you should be able to edit this file to copy this into place here 😄
https://github.com/brave/brave-core/blob/75160cdef73e9710c7f1eddc3ef48736173511fc/build/commands/lib/util.js#L218-L271

You'll need to make a new line for translating brave's src/brave/components/neterror/resources/images/default_100_percent/offline/100-offline-sprite.png => Chromiums src/components/neterror/resources/images/default_100_percent/offline/100-offline-sprite.png with a fileMap.add

Let me know if this makes sense! 😄

[EnzoItaliano]

@bsclifton Ok, now it worked. To make a commit in my fork, do I have to create a new branch or just a commit with the name Fixes brave/brave-browser#17124 ? And then a pull request with this same name?

[bsclifton]

@EnzoItaliano it's preferred you make a branch in your fork (rather than using master/main)- but then you can make a commit message like you're saying 😄 Something like:

Update Chrome logo to Brave logo

Fixes brave/brave-browser#17124

Then you can submit pull request and I can help you from there 😄

[EnzoItaliano]

@bsclifton appreciate your help, thanks 😁

[thebarshablog]

Is work on this issue still going on?

[VinayMayavanshi13]

Let me try into this...

[VinayMayavanshi13]

@bsclifton Even after a full clone and running npm run init, I don't see any components file under src folder. Also to solve the issue I tried to first erase the chrome icon in both png photos and added brave icon but it didn't worked something seemed to be broken. Other way which I tried is to erase the chrome icon from both png images and keep them as it is, but still it did not work. Also to be honest let us discard this offline dino game feature and let us put up something else.

[EnzoItaliano]

@VinayMayavanshi13 I suggest you to take a look on my commits and on this message #17124 (comment) you're going to find some answers you need

[VinayMayavanshi13]

@bsclifton I see the issue has already been closed by @EnzoItaliano but that's on Brave Core Repository. The solution has not yet reflected on the brave browser as the brave core repository is way too behind in commits from the brave-main repo. Is there any thing I can do about it?

[EnzoItaliano]

@VinayMayavanshi13 actually the issue is still open, just my PR was closed

[VinayMayavanshi13]

Got it.

[swaindhruti]

I tried to clone the browser repo and tried to build and run locally and encountered the error while running npm run build added screenshot below:

These are the commands i ran before the npm run build:

1. git clone git@github.com-personal:coder-XX04/brave-browser.git
2. git clone git@github.com-personal:brave/brave-core.git D:/WDGIT/brave-browser/src/brave
3. npm install
4. npm audit fix
5. npm audit fix --force

Can anyone please suggest how to tackle this issue?

[bsclifton]

@coder-XX04 from your current path (D:\WDGIT\brave-browser), you'll want to run npm run init

That will pull down the brave-core for you and pull down the Chromium source too

[swaindhruti]

Thanks for your suggestion, but i tried to run that but got an error msg shown as below:

I cloned this project into a separate drive i installed on my device is that causing the problem??
Can you plz provide the way to install the missing modules as it says in the error.

[bsclifton]

@coder-XX04 ah - I think I ran into this too. Can you please try updating NPM? I think it can be updated via
npm i -g npm

After that, you can try the init again

[swaindhruti]

Yes, Updated the npm then ran npm run init I think it's working now it downloading the chrome dependencies.Thanks for helping me out as a opensource contributor beginner you were a huge help.I will keep updated as long as I proceed.😊

[swaindhruti]

@bsclifton When I am trying to run npm start it shows the following message:
I opened the brave-browser folder in VS Code then using the terminal I ran the npm start command.
Can you please help me to overcome this situation

And one more thing is chromium source and brave core combined are supposed to around 75GB on disk?

[bsclifton]

OK after you do npm run init, you can do the next step... building. You can cd to src/brave like you did. And then run npm run build

The size is quite large - definitely around 75GB, it can be more if you have multiple types of build (debug, release)

[swaindhruti]

@bsclifton is it okay to npm run build in brave-browser repo rather than CD into src/Brave because I think I have run npm run build directly in the brave-browser repo without CD into src/Brave.

[bsclifton]

@coder-XX04 yeah it shouldn't matter which one you run it from. I usually run from inside src/brave

[swaindhruti]

@bsclifton I ran the npm run build ir shows the following error:

Then i ran npm start it showed the same error as i gave the screenshot earlier. I am not getting whats the problem is i followed all the steps to end correctly as told in the documentation.

[bsclifton]

@coder-XX04 do you have Visual Studio 2022 installed? I believe this just recently became a requirement (and we didn't update our wiki yet)
https://chromium.googlesource.com/chromium/src/+/master/docs/windows_build_instructions.md#visual-studio

[swaindhruti]

Oh, yes, I have it installed but it is not yet set up as per the instructions. Let me give it a try and then try to build it. Thanks for the clarification; I will keep updating as I proceed.

[swaindhruti]

@bsclifton I installed and set up all the necessary resources according to the prerequisites and installed the brave-browser and then used all the commands according to the prerequisite and when I tried to run the npm run build it went well but a new error occurred (screenshot provided below) this time it shows file not found error, but all the installation was successful.

The scenario while building:

The error midway:

Can you plz suggest some ways how to tackle this because this time the setup is all accurate and if this is tackled i will be able to contribute to brave.

[bsclifton]

@coder-XX04 something you might try is moving the build directory (C:\Users\dhrut\Desktop\GITHUB-MAIN\coder-XX04\brave-browser) to the root of your drive; something like:
C:\brave-browser or C:\GitHub\brave-browser

I haven't seen a problem in a while - but there have been times where the path is too long. Another thing would be to check if you have enough disk space. But try moving the path and let us know

[rielAsh24]

@bsclifton Hey! I wish to contribute potential solutions to this issue, in case it has not been resolved.