Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabling Brave Rewards does not stop the "Brave Ads Service" or "Bat Ledger Service" from running #17491

Closed
elsubigo opened this issue Aug 15, 2021 · 12 comments · Fixed by brave/brave-core#9796
Closed

Disabling Brave Rewards does not stop the "Brave Ads Service" or "Bat Ledger Service" from running #17491

elsubigo opened this issue Aug 15, 2021 · 12 comments · Fixed by brave/brave-core#9796
Assignees
@tmancey
Labels
bug feature/ads feature/brave-news formerly brave-today OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
Ads
Milestone
1.30.x - Release

Comments

@elsubigo
Copy link

Description

Disabling Brave Rewards on MacOS Big Sur 11.4 does not stop the "Brave Ads Service" or "Bat Ledger Service" from running in the background. Launching the app with the --disable-brave-rewards-extension or --disable-brave-extension flags won't work either. I've tried this on a fresh install with rewards not enabled, as well as an old install with rewards turned on/off again.

Not only will the services not disable, they remain among the highest users of memory/CPU when at an idle.

Steps to Reproduce

  1. Launch Brave on MacOS. Disable rewards in settings. Check built in task manager.
  2. Launch Brave with --disable-brave-rewards-extension / --disable-brave-extension flags from CLI. Check built in task manager.

Actual result:

"Brave Ads Service" and "Bat Ledger Service" continue to run.

Expected result:

"Brave Ads Service" and "Bat Ledger Service" should not have active services running.

Reproduces how often:

100% of the time.

Brave version (info found on brave://version)

Version 1.28.105 Chromium: 92.0.4515.131 (Official Build) (x86_64)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? No
  • Does the issue resolve itself when disabling Brave Rewards? No
@srirambv
Copy link
Contributor

cc: @tmancey

@bsclifton bsclifton added this to New issues in Ads via automation Aug 16, 2021
@bsclifton bsclifton added this to New Issues in Brave Rewards via automation Aug 16, 2021
@bsclifton bsclifton added the needs-investigation A bug not 100% confirmed/fixed label Aug 16, 2021
@tmancey tmancey self-assigned this Aug 16, 2021
@tmancey tmancey removed this from New Issues in Brave Rewards Aug 16, 2021
@tmancey tmancey moved this from New issues to In progress in Ads Aug 16, 2021
@tmancey
Copy link
Contributor

tmancey commented Aug 16, 2021

@srirambv this is correct if a user opts in to Brave News. Can you please confirm you were opted-in to Brave News

@tmancey tmancey closed this as completed Aug 16, 2021
Ads automation moved this from In progress to Done Aug 16, 2021
@elsubigo
Copy link
Author

Why is this being marked closed?

And to answer the question, yes, this was tested while opting in and out of Brave News.

@tmancey
Copy link
Contributor

tmancey commented Aug 16, 2021

@elsubigo would you be willing to screen-share so I can investigate further, if so can you please reach out to tmancey@brave.com so I can send a link. Thanks

@tmancey
Copy link
Contributor

tmancey commented Aug 16, 2021

If you are opted-in to Brave News then the ads service will be running. This is as expected.

@elsubigo
Copy link
Author

Screenshots:

1

2

3

@bsclifton bsclifton reopened this Aug 16, 2021
Ads automation moved this from Done to In progress Aug 16, 2021
@bsclifton
Copy link
Member

Re-opening: we might have a bug where disabling News isn't resetting the conditions needed to start the service

@bsclifton bsclifton added feature/brave-news formerly brave-today and removed closed/invalid labels Aug 16, 2021
@tmancey tmancey added priority/P2 A bad problem. We might uplift this to the next planned release. and removed needs-investigation A bug not 100% confirmed/fixed labels Aug 17, 2021
@bsclifton bsclifton mentioned this issue Aug 17, 2021
Closed
4 tasks
@bsclifton
Copy link
Member

Visiting brave://rewards will always start the Ledger service, even if you reset your wallet. However, if you close all instances of brave://rewards and quit/re-open Brave Ledger service WILL NOT be running. See #14277 for more info

I did confirm this issue (Ads service running) though; turning OFF News doesn't stop the Ads service from running. I would expect as a user that ads service should NOT be running when:

  1. rewards has not been enabled (specifically ads)
    AND
  2. Brave News is disabled

@tmancey tmancey moved this from In progress to Review in Ads Aug 19, 2021
@tmancey tmancey added the QA/Yes label Aug 19, 2021
@tmancey
Copy link
Contributor

tmancey commented Aug 19, 2021

@bsclifton Thanks, I can confirm "I did confirm this issue (Ads service running) though; turning OFF News doesn't stop the Ads service from running. I would expect as a user that ads service should NOT be running" is a bug. Raising a PR now against this issue.

@tmancey tmancey mentioned this issue Aug 19, 2021
Merged
24 tasks
Ads automation moved this from Review to Done Aug 20, 2021
@tmancey tmancey added this to the 1.30.x - Nightly milestone Aug 20, 2021
@tmancey tmancey added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P2 A bad problem. We might uplift this to the next planned release. labels Aug 20, 2021
@stephendonner stephendonner added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 23, 2021
@stephendonner
Copy link

stephendonner commented Aug 23, 2021 •
edited by GeetaSarvadnya
Loading

** Verified PASSED using

Brave 1.30.41 Chromium: 93.0.4577.51 (Official Build) nightly (x86_64)
Revision 762d21050e2da59930c784c09b134d0b0b148188-refs/branch-heads/4577@{#915}
OS macOS Version 11.5.2 (Build 20G95)

Steps:

Case 1: Ads Enabled & Brave News Ads Enabled > Ads service should be running

  1. new profile
  2. launch Brave
  3. enabled Ads & Rewards via clicking on the BAT icon and clicking Start using Rewards
  4. enabled Brave News via new-tab page, Customize -> Brave News -> Show Brave News
  5. Window -> Task Manager

Screen Shot 2021-08-23 at 14 21 35

Confirmed BAT Ad Service was running in Task Manager

Case 2: Ads Enabled & Brave News Ads Disabled > Ads service should be running

  1. new profile
  2. launch Brave
  3. enabled Ads & Rewards via clicking on the BAT icon and clicking Start using Rewards
  4. ensured Brave News was disabled already via new-tab page, Customize -> Brave News -> Show Brave News
  5. Window -> Task Manager

Screen Shot 2021-08-23 at 14 22 29

Confirmed BAT Ad Service was running in Task Manager

Case 3: Ads Disabled & Brave News Ads Enabled > Ads service should be running

  1. new profile
  2. launch Brave
  3. ensured Ads & Rewards were disabled by default via brave://rewards
  4. enabled Brave News via new-tab page, Customize -> Brave News -> Show Brave News
  5. Window -> Task Manager

Screen Shot 2021-08-23 at 14 23 25

Confirmed BAT Ad Service was running in Task Manager

Case 4: Ads Disabled & Brave News Ads Disabled > Ads service should not be running

  1. new profile
  2. launch Brave
  3. ensured Ads & Rewards were disabled by default via brave://rewards
  4. ensured Brave News was disabled already via new-tab page, Customize -> Brave News -> Show Brave News
  5. Window -> Task Manager

Screen Shot 2021-08-23 at 14 24 11

Confirmed BAT Ad Service was NOT running in Task Manager

Verification passed on

Brave 1.30.65 Chromium: 93.0.4577.63 (Official Build) beta (64-bit)
Revision ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS Ubuntu 18.04 LTS

Verified the above test plan

Case 1: Ads Enabled & Brave News Ads Enabled > Ads service should be running

image

Confirmed BAT Ad Service was running in Task Manager

Case 2: Ads Enabled & Brave News Ads Disabled > Ads service should be running

image

Confirmed BAT Ad Service was running in Task Manager

Case 3: Ads Disabled & Brave News Ads Enabled > Ads service should be running

image

Confirmed BAT Ad Service was running in Task Manager

Case 4: Ads Disabled & Brave News Ads Disabled > Ads service should not be running

image

Encountered issue mentioned in #17491 (comment)
image

Confirmed BAT Ad Service was NOT running in Task Manager

Verification passed on

Brave | 1.30.65 Chromium: 93.0.4577.63 (Official Build) beta (64-bit)
-- | --
Revision | ff5c0da2ec0adeaed5550e6c7e98417dac77d98a-refs/branch-heads/4577@{#1135}
OS | Windows 10 OS Version 2009 (Build 19043.1165)

Case 1: Ads Enabled & Brave News Ads Enabled > Ads service should be running

Confirmed BAT Ad Service is running in Task Manager
image

Case 2: Ads Enabled & Brave News Ads Disabled > Ads service should be running

Confirmed BAT Ad Service is running in Task Manager
image

Case 3: Ads Disabled & Brave News Ads Enabled > Ads service should be running

Confirmed BAT Ad Service is running in Task Manager
image

Case 4: Ads Disabled & Brave News Ads Disabled > Ads service should not be running

Confirmed BAT Ad Service was NOT running in Task Manager
image

@stephendonner stephendonner added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 23, 2021
@LaurenWags
Copy link
Member

cc @tmancey - should this be checked on Windows and Linux also?

@tmancey
Copy link
Contributor

tmancey commented Sep 2, 2021

@LaurenWags I would recommend checking on Windows and Linux

@LaurenWags LaurenWags changed the title Disabling Brave Rewards on MacOS does not stop the "Brave Ads Service" or "Bat Ledger Service" from running Disabling Brave Rewards does not stop the "Brave Ads Service" or "Bat Ledger Service" from running Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads feature/brave-news formerly brave-today OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
Ads
Archived in project
Ads
  
Done
Milestone
1.30.x - Release
Development

Successfully merging a pull request may close this issue.

Fixes hiding Brave Today should stop the ads service if Brave ads is not enabled brave/brave-core
8 participants
@stephendonner @tmancey @bsclifton @srirambv @LaurenWags @btlechowski @GeetaSarvadnya @elsubigo