Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement eth_sign and related functions for signging #17986

Closed
bbondy opened this issue Sep 10, 2021 · 1 comment · Fixed by brave/brave-core#10433
Closed

Implement eth_sign and related functions for signging #17986

bbondy opened this issue Sep 10, 2021 · 1 comment · Fixed by brave/brave-core#10433
Assignees
@darkdh
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
Wallet
Milestone
1.32.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Sep 10, 2021

eth_sign <- we should add a warning for this because it can be used to sign transaction
personal_sign
signTypedData / signTypedData_v1
signTypedData_v3
signTypedData_v4
@bbondy bbondy added OS/Android Fixes related to Android browser functionality OS/Desktop labels Sep 10, 2021
@bbondy bbondy added this to Untriaged in Wallet via automation Sep 10, 2021
@bbondy bbondy moved this from Untriaged to Backlog (MVP) in Wallet Sep 10, 2021
@spylogsster spylogsster mentioned this issue Sep 23, 2021
Closed
@darkdh darkdh moved this from Backlog (MVP) to In progress in Wallet Oct 4, 2021
@darkdh
Copy link
Member

darkdh commented Oct 8, 2021

signTypedData will be implemented in
#17986

UI integration will be in #18660

@darkdh darkdh mentioned this issue Oct 8, 2021
Merged
24 tasks
@darkdh darkdh moved this from In progress to In Review in Wallet Oct 8, 2021
Wallet automation moved this from In Review to Closed Oct 10, 2021
@darkdh darkdh added this to the 1.32.x - Nightly milestone Oct 10, 2021
@srirambv srirambv added the feature/web3/wallet Integrating Ethereum+ wallet support label Nov 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@darkdh darkdh

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop QA/No release-notes/exclude
Projects
No open projects
Wallet
Closed
Milestone
1.32.x - Release
Development

Successfully merging a pull request may close this issue.

Support eth_sign and personal_sign brave/brave-core
3 participants
@bbondy @darkdh @srirambv