Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove View on Block Explorer button for rejected transactions #19454

Closed
onyb opened this issue Nov 15, 2021 · 0 comments · Fixed by brave/brave-core#11325
Closed

Remove View on Block Explorer button for rejected transactions #19454

onyb opened this issue Nov 15, 2021 · 0 comments · Fixed by brave/brave-core#11325
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Milestone
1.34.x - Release

Comments

@onyb
Copy link
Member

onyb commented Nov 15, 2021

Rejected transactions do not exist on-chain, so we shouldn't display the "View on Block Explorer" link for them.

image
@onyb onyb added QA/No release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Nov 15, 2021
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Nov 26, 2021
@muliswilliam muliswilliam mentioned this issue Nov 29, 2021
Merged
24 tasks
@muliswilliam muliswilliam added this to the 1.34.x - Beta milestone Dec 9, 2021
@LaurenWags LaurenWags mentioned this issue Jan 4, 2022
Closed
@srirambv srirambv mentioned this issue Feb 7, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/include
Projects
None yet
Milestone
1.34.x - Release
Development

Successfully merging a pull request may close this issue.

Remove View on Block Explorer button for rejected transactions brave/brave-core
3 participants
@bbondy @onyb @muliswilliam