Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sign using Trezor fails on Cryptokitties.co #19504

Closed
srirambv opened this issue Nov 16, 2021 · 4 comments · Fixed by brave/brave-core#11967
Closed

Sign using Trezor fails on Cryptokitties.co #19504

srirambv opened this issue Nov 16, 2021 · 4 comments · Fixed by brave/brave-core#11967
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include

Comments

@srirambv
Copy link
Contributor

Description

Sign using Trezor fails on Cryptokitties.co

Steps to Reproduce

  1. Connect Trezor
  2. Visit cryptokitties.co and try to sign mesage via trezor wallet
  3. Sign message popup goes into loop

Actual result:

Sign using Trezor fails on Cryptokitties.co

Expected result:

Should be able to sign message using Trezor wallet

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.32.106 Chromium: 96.0.4664.45 (Official Build) (x86_64)
Revision 76e4c1bb2ab4671b8beba3444e61c0f17584b2fc-refs/branch-heads/4664@{#947}
OS All

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes when released
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @onyb @spylogsster

@srirambv srirambv added bug needs-investigation A bug not 100% confirmed/fixed QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop labels Nov 16, 2021
@bbondy bbondy added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 16, 2021
@spylogsster
Copy link

spylogsster commented Nov 22, 2021

@srirambv can you please try to remove all cookies for https://www.cryptokitties.co/ and sign message again. seems working for me

@srirambv
Copy link
Contributor Author

Issue still reproducible on 1.34.40 on a clean profile

@srirambv
Copy link
Contributor Author

Seems to be an issue on 1.35.89 as well. Shared recording with @spylogsster

@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.35.98 Chromium: 98.0.4758.74 (Official Build) (arm64)
Revision d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS macOS Version 12.1 (Build 21C52)
  • Verified steps from issue description
  • Verified able to sign message and login successfully using a Trezor wallet

Verification passed on

Brave 1.35.98 Chromium: 98.0.4758.74 (Official Build) (64-bit)
Revision d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS Windows 11 Version Dev (Build 22543.1000)
  • Verified steps from issue description
  • Verified able to sign message and login successfully using a Trezor wallet

Verification passed on

Brave 1.35.98 Chromium: 98.0.4758.74 (Official Build) (64-bit)
Revision d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS Linux
  • Verified steps from issue description
  • Verified able to sign message and login successfully using a Trezor wallet

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support needs-investigation A bug not 100% confirmed/fixed OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants