Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to disable autocomplete completely #19647

Closed
samartnik opened this issue Nov 22, 2021 · 1 comment · Fixed by brave/brave-core#11784
Closed

Add an option to disable autocomplete completely #19647

samartnik opened this issue Nov 22, 2021 · 1 comment · Fixed by brave/brave-core#11784

Comments

@samartnik
Copy link
Contributor

samartnik commented Nov 22, 2021

Description

Currently we have 3 options that control autocompletion, but, even when all of them are turned off, autocomplete still uses history and bookmarks for completion. So we need to add an option to disable autocomplete completely to be on par with desktop.

Steps to reproduce

  1. Visit some websites to collect a history.
  2. Disable all 3 switches for autocompletion in privacy settings.
  3. Start typing one of the previously visited web site. It will still suggest it.

Actual result

No option to control autocompletion in general.

Expected result

Add option to control autocompletion in general.

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@samartnik samartnik added the OS/Android Fixes related to Android browser functionality label Nov 22, 2021
@samartnik samartnik added this to Backlog in Android General via automation Nov 22, 2021
@samartnik samartnik self-assigned this Nov 22, 2021
Android General automation moved this from Backlog to Done/Closed Jan 8, 2022
@samartnik samartnik added this to the 1.36.x - Nightly milestone Jan 8, 2022
@Uni-verse
Copy link
Contributor

Uni-verse commented Feb 10, 2022

Verification PASSED on Samsung Galaxy S21 running Android 12 using build version 1.36.90, Chromium 98.0.4758.87

Scenarios tested:

  • Main autocomplete toggle is added under settings > Brave Shields & privacy
  • Disabling main/general autocomplete toggle disables the existing autocomplete options
  • Regular tabs - Disabling main autocomplete in settings disables autocomplete in address bar
  • Private tabs - Disabling main autocomplete in settings disables autocomplete in address bar
  • Disabling main toggle while other autocomplete options are enabled prevents autocomplete in address tab

Android UI
Screenshot_20220211-042457_Brave - Beta


Verification passed on Samsung Tab A with Android 10 running 1.36.105 x64 build

  • Verified new setting for global auto-complete option is available under Settings -> Brave Shields and privacy
  • Verified disabling the main setting disables all forms of autocomplete
  • Verified enabled/disable setting affects both normal tabs and private tabs
19674-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment