Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding summary for Show autocomplete in address bar toggle #21287

Closed
kjozwiak opened this issue Feb 24, 2022 · 3 comments · Fixed by brave/brave-core#13721
Closed

adding summary for Show autocomplete in address bar toggle #21287

kjozwiak opened this issue Feb 24, 2022 · 3 comments · Fixed by brave/brave-core#13721

Comments

@kjozwiak
Copy link
Member

Description

We should add a short summary under the Show autocomplete in address bar setting that explains what it does as we have several autocomplete settings available which might confuse users.

For reference, it was added in 1.36.x via #19647.

Steps to reproduce

  1. launch 1.36.x (this was added via Add an option to disable autocomplete completely #19647)
  2. go into Hamburger Menu -> Settings -> Brave Shields & privacy
  3. scroll to the bottom and notice that Show autocomplete in address bar doesn't have a summary

Actual result

image

Expected result

We should add a short summary to explain what this toggle does as users might get confused/not have enough context

Issue reproduces how often

100% reproducible using the STR mentioned above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? N/A (it will be once 1.36.x is released)
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Pixel 6
  • Android version: Android 12

Brave version

1.37.67 Chromium: 99.0.4844.35

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @anthonypkeane

@kjozwiak kjozwiak added QA/Yes feature/autocomplete feature/settings OS/Android Fixes related to Android browser functionality labels Feb 24, 2022
@kjozwiak kjozwiak added this to Backlog in Android General via automation Feb 24, 2022
@timchilds timchilds self-assigned this Jun 8, 2022
@timchilds
Copy link

@rmcfadden3 can you please help with copy for the summary? Something like:

Displays website suggestions in the address bar based on your history and bookmarks.

@rmcfadden3
Copy link

@timchilds — I like your description. Just a couple small tweaks to:

"Displays website suggestions based on your bookmarks and browsing history."

I removed "in the address bar" since that info already appears in the name of the setting.

@kjozwiak
Copy link
Member Author

Verification PASSED on Pixel 6 running Android 13 using the following build(s):

Brave | 1.41.82 Chromium: 103.0.5060.66 (Official Build) beta (32-bit)
--- | ---
Revision | 20b1569438a85e631d15e83eb355e3e326e5da6f-refs/branch-heads/5060@{#1066}
OS | Android 13;

summaryUpdate

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants