Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Tor to Brave Search #20583

Closed
rebron opened this issue Jan 20, 2022 · 7 comments · Fixed by brave/brave-core#11916 or brave/brave-core#12391
Closed

Update Tor to Brave Search #20583

rebron opened this issue Jan 20, 2022 · 7 comments · Fixed by brave/brave-core#11916 or brave/brave-core#12391
Assignees
@emerick @simonhong
Labels
Brave Search feature/search feature/tor OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
1.36.x - Release #4

Comments

@rebron
Copy link
Collaborator

rebron commented Jan 20, 2022 •
edited
Loading

Description

For New Private Window with Tor, default search engine should be Brave Search.
https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q=%s

Will also need to update the New Private Window with Tor new tab page to remove reference to DuckDuckGo.

Steps to Reproduce

  1. Open New Private Window with Tor
  2. Enter search terms in the url bar. Should say Search Brave or type a URL
  3. Should go to Brave Search.

Actual result:

Currently defaults to DuckDuckGo search.

Screen Shot 2022-01-18 at 12 07 28 PM

Expected result:

See description.
https://www.figma.com/file/5THkuEtO2Ewn9LfqrHZP9a/Desktop-Private-and-TOR-Windows?node-id=942%3A19384

Screen Shot 2022-01-18 at 12 07 10 PM

Reproduces how often:

Easily.

Brave version (brave://version info)

Target version for update 1.36.x

Version/Channel Information:

  • Can you reproduce this issue with the current release? yes
  • Can you reproduce this issue with the beta channel? yes
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Does the issue resolve itself when disabling Brave Rewards? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Miscellaneous Information:
@simonhong simonhong self-assigned this Jan 20, 2022
@rebron rebron added this to In progress in General Jan 20, 2022
simonhong added a commit to brave/brave-core that referenced this issue Jan 20, 2022
@simonhong
Use brave search as a default search provider in tor window
164d453 
fix brave/brave-browser#20583
simonhong added a commit to brave/brave-core that referenced this issue Jan 20, 2022
@simonhong
Use brave search as a default search provider in tor window
d2508db 
fix brave/brave-browser#20583
@simonhong simonhong mentioned this issue Jan 20, 2022
Merged
25 tasks
@diracdeltas
Copy link
Member

this was blocked on https://github.com/brave/internal/issues/781 - were all those items done?

@emerick emerick mentioned this issue Jan 24, 2022
Closed
25 tasks
simonhong added a commit to brave/brave-core that referenced this issue Jan 25, 2022
@simonhong
Use brave search as a default search provider in tor window
d97ab08 
fix brave/brave-browser#20583
@rebron rebron moved this from In progress to Pending review/uplift in General Jan 25, 2022
simonhong added a commit to brave/brave-core that referenced this issue Jan 26, 2022
@simonhong
Use brave search as a default search provider in tor window
3fdcba2 
fix brave/brave-browser#20583
simonhong added a commit to brave/brave-core that referenced this issue Jan 26, 2022
@simonhong
Use brave search as a default search provider in tor window
4a9c83f 
fix brave/brave-browser#20583
simonhong added a commit to brave/brave-core that referenced this issue Feb 3, 2022
@simonhong
Use brave search as a default search provider in tor window
607f6f9 
fix brave/brave-browser#20583
simonhong added a commit to brave/brave-core that referenced this issue Feb 3, 2022
@simonhong
Use brave search as a default search provider in tor window
93527ee 
fix brave/brave-browser#20583
@rebron
Copy link
Collaborator Author

rebron commented Feb 22, 2022

Per @fmarier https://github.com/brave/search/issues/3425#issuecomment-1043657123 Let's get this merged down.

General automation moved this from Pending review/uplift to Completed Feb 23, 2022
@simonhong simonhong added this to the 1.37.x - Nightly milestone Feb 23, 2022
@bsclifton bsclifton reopened this Feb 24, 2022
@bsclifton bsclifton removed this from the 1.37.x - Nightly milestone Feb 24, 2022
@bsclifton
Copy link
Member

Reopening after revert via brave/brave-core#12390

@simonhong simonhong added this to the 1.38.x - Nightly milestone Mar 8, 2022
@simonhong simonhong mentioned this issue Mar 8, 2022
Merged
25 tasks
@rebron rebron moved this from Completed to Pending review/uplift in General Mar 8, 2022
@kjozwiak
Copy link
Member

kjozwiak commented Mar 14, 2022 •
edited
Loading

@brave/legacy_qa some of the cases that I ran through via brave/brave-core#12391 (comment) can be used to verify the above as well.

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Mar 15, 2022 •
edited
Loading

Verification PASSED on


Brave | 1.36.115 Chromium: 99.0.4844.51 (Official Build) (64-bit)
-- | --
Revision | d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS | Windows 10 Version 21H2 (Build 19044.1586)
  • Verified the STR mentioned in the description
  • Confirmed open a TOR window displays the text as Search Brave or type a URL in the URL bar
  • Confirmed search is performed by using the Brave SE
  • Confirmed that CAPTCHA test is being done whenever searching via the Tor window
Example Example Example
image image image

Test Case #1 - Clean Install

  • ensured that Brave Search is the default SE for both Normal/Private windows
  • ensured that Brave Search is the default SE for Tor Windows and ensured that the .onion address is being used
    • https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q
  • ensured that https://search.brave.com/search?q= is still being used under Normal & Private windows
  • ensured that there's no mention of DDG anywhere under the Tor window nor any images associated with DDG
  • ensured that the progress bar correctly indicates when Tor is being downloaded/connecting and connected successfully
  • ensured that Brave Search is only listed once under brave://settings/search & brave://settings/searchEngines
  • ensured that the :search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion keyword is working as expected
  • ensured that changing defaults via brave://settings/searchEngines doesn't affect the default Tor SE (should always be Brave)
Example Example Example Example Example
image image image image image

CAPTCHA screens whenever searching via the Tor window
image

Test Case #2 - Upgrade (Other SE default other than Brave Search)

  • downloaded/installed 1.36.112
  • ensured that the Tor window mentions that DDG is the default SE
  • ensured that the Tor window is using https://duckduckgo.com/?q= as the default SE
  • changed the default SE to Startpage via brave://settings/search
  • ensured that Startpage is set as the default SE via brave://settings/searchEngines
  • Upgraded to 1.36.115
  • ensured that Startpage is still the default SE under brave://settings/search & brave://settings/searchEngines
  • ensured that there's no duplicates being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that all mentions of DDG are removed from the Tor window
  • ensured that https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q= is the default SE

Before - 1.36.112

Example Example Example
image image image

After - 1.36.115

Example Example Example Example Example
image image image image image

Test Case #3 - Upgrade (Brave Search as default)

  • downloaded/installed 1.36.112
  • ensured that the Tor window mentions that DDG is the default SE
  • ensured that the Tor window is using https://duckduckgo.com/?q= as the default SE
  • changed the default SE to Brave via brave://settings/search
  • ensured that Brave is set as the default SE via brave://settings/searchEngines
  • Upgraded to 1.36.115
  • ensured that Brave is still the default SE under brave://settings/search & brave://settings/searchEngines
  • ensured that there's no duplicates being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that all mentions of DDG are removed from the Tor window
  • ensured that https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q= is the default SE

Before - 1.36.112

Example Example Example
image image image

After - 1.36.115

Example Example Example Example Example
image image image image image

@rebron rebron moved this from Pending review/uplift to Completed in General Mar 15, 2022
@rebron rebron mentioned this issue Mar 15, 2022
Closed
@LaurenWags LaurenWags mentioned this issue Mar 15, 2022
Closed
@stephendonner
Copy link

Verified PASSED using

Brave 1.36.115 Chromium: 99.0.4844.51 (Official Build) (x86_64)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS macOS Version 11.6.3 (Build 20G415)

Verification PASSED on

  • Verified the STR mentioned in the description
  • Confirmed open a TOR window displays the text as Search Brave or type a URL in the URL bar
  • Confirmed search is performed by using the Brave SE
  • Confirmed that CAPTCHA test is being done whenever searching via the Tor window
Example Example Example
Screen Shot 2022-03-15 at 12 04 55 PM Screen Shot 2022-03-15 at 12 05 24 PM Screen Shot 2022-03-15 at 1 25 49 PM

Test Case #1 - Clean Install

  • ensured that Brave Search is the default SE for both Normal/Private windows
  • ensured that Brave Search is the default SE for Tor Windows and ensured that the .onion address is being used
    • https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q
  • ensured that https://search.brave.com/search?q= is still being used under Normal & Private windows
  • ensured that there's no mention of DDG anywhere under the Tor window nor any images associated with DDG
  • ensured that the progress bar correctly indicates when Tor is being downloaded/connecting and connected successfully
  • ensured that Brave Search is only listed once under brave://settings/search & brave://settings/searchEngines
  • ensured that the :search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion keyword is working as expected
  • ensured that changing defaults via brave://settings/searchEngines doesn't affect the default Tor SE (should always be Brave)
Example Example Example Example Example
Screen Shot 2022-03-15 at 12 04 48 PM Screen Shot 2022-03-15 at 12 04 55 PM Screen Shot 2022-03-15 at 12 07 53 PM Screen Shot 2022-03-15 at 12 10 43 PM

CAPTCHA screens whenever searching via the Tor window

Screen Shot 2022-03-15 at 12 05 24 PM

Test Case #2 - Upgrade (Other SE default other than Brave Search)

  • downloaded/installed 1.36.112
  • ensured that the Tor window mentions that DDG is the default SE
  • ensured that the Tor window is using https://duckduckgo.com/?q= as the default SE
  • changed the default SE to Ecosia via brave://settings/search
  • ensured that Ecosia is set as the default SE via brave://settings/searchEngines
  • Upgraded to 1.36.115
  • ensured that Ecosia is still the default SE under brave://settings/search & brave://settings/searchEngines
  • ensured that there's no duplicates being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that all mentions of DDG are removed from the Tor window
  • ensured that https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q= is the default SE

Before - 1.36.112

Example Example Example
image image image

After - 1.36.115

Example Example Example Example Example
image image image image image

Test Case #3 - Upgrade (Brave Search as default)

  • downloaded/installed 1.36.112
  • ensured that the Tor window mentions that DDG is the default SE
  • ensured that the Tor window is using https://duckduckgo.com/?q= as the default SE
  • changed the default SE to Brave via brave://settings/search
  • ensured that Brave is set as the default SE via brave://settings/searchEngines
  • Upgraded to 1.36.115
  • ensured that Brave is still the default SE under brave://settings/search & brave://settings/searchEngines
  • ensured that there's no duplicates being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that all mentions of DDG are removed from the Tor window
  • ensured that https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q= is the default SE

Before - 1.36.112

Example Example Example
image image image

After - 1.36.115

Example Example Example Example Example
Screen Shot 2022-03-15 at 1 27 28 PM Screen Shot 2022-03-15 at 1 12 05 PM Screen Shot 2022-03-15 at 1 25 49 PM Screen Shot 2022-03-15 at 1 34 31 PM Screen Shot 2022-03-15 at 1 34 36 PM

@btlechowski
Copy link

Verification passed on

Brave 1.36.115 Chromium: 99.0.4844.51 (Official Build) (64-bit)
Revision d537ec02474b5afe23684e7963d538896c63ac77-refs/branch-heads/4844@{#875}
OS Ubuntu 18.04 LTS
  • Verified the STR mentioned in the description
  • Confirmed open a TOR window displays the text as Search Brave or type a URL in the URL bar
  • Confirmed search is performed by using the Brave SE
  • Confirmed that CAPTCHA test is being done whenever searching via the Tor window
![image](https://user-images.githubusercontent.com/34715963/158485034-78e37409-094d-45ab-81f9-b1adb05d075c.png) ![image](https://user-images.githubusercontent.com/34715963/158485215-cbbc96a7-89da-466a-a495-aa9588f1041d.png) ![image](https://user-images.githubusercontent.com/34715963/158485264-7fba6103-f7a0-47a6-a5d9-0583394f822d.png)

Test Case #1 - Clean Install

  • ensured that Brave Search is the default SE for both Normal/Private windows
  • ensured that Brave Search is the default SE for Tor Windows and ensured that the .onion address is being used
    • https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q
  • ensured that https://search.brave.com/search?q= is still being used under Normal & Private windows
  • ensured that there's no mention of DDG anywhere under the Tor window nor any images associated with DDG
  • ensured that the progress bar correctly indicates when Tor is being downloaded/connecting and connected successfully
  • ensured that Brave Search is only listed once under brave://settings/search & brave://settings/searchEngines
  • ensured that the :search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion keyword is working as expected
  • ensured that changing defaults via brave://settings/searchEngines doesn't affect the default Tor SE (should always be Brave)

image
image
image
image
image
image

Test Case #2 - Upgrade (Other SE default other than Brave Search)

  • downloaded/installed 1.36.112
  • ensured that the Tor window mentions that DDG is the default SE
  • ensured that the Tor window is using https://duckduckgo.com/?q= as the default SE
  • changed the default SE to Ecosia via brave://settings/search
  • ensured that Ecosia is set as the default SE via brave://settings/searchEngines
  • Upgraded to 1.36.115
  • ensured that Ecosia is still the default SE under brave://settings/search & brave://settings/searchEngines
  • ensured that there's no duplicates being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that all mentions of DDG are removed from the Tor window
  • ensured that https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q= is the default SE

Before - 1.36.112

image
image

After - 1.36.115

image
image
image

Test Case #3 - Upgrade (Brave Search as default)

  • downloaded/installed 1.36.112
  • ensured that the Tor window mentions that DDG is the default SE
  • ensured that the Tor window is using https://duckduckgo.com/?q= as the default SE
  • changed the default SE to Brave via brave://settings/search
  • ensured that Brave is set as the default SE via brave://settings/searchEngines
  • Upgraded to 1.36.115
  • ensured that Brave is still the default SE under brave://settings/search & brave://settings/searchEngines
  • ensured that there's no duplicates being listed under brave://settings/search & brave://settings/searchEngines
  • ensured that all mentions of DDG are removed from the Tor window
  • ensured that https://search.brave4u7jddbv7cyviptqjc7jusxh72uik7zt6adtckl5f4nwy2v72qd.onion/search?q= is the default SE

Before - 1.36.112

image
image

After - 1.36.115

image
image
image

@rebron rebron removed this from Completed in General Mar 16, 2022
@kjozwiak kjozwiak mentioned this issue Mar 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

@simonhong simonhong

Labels
Brave Search feature/search feature/tor OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
1.36.x - Release #4
9 participants
@stephendonner @diracdeltas @kjozwiak @bsclifton @emerick @rebron @simonhong @btlechowski @GeetaSarvadnya