Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce TileFavicon sizes in "New Tab" #12062

Closed
wants to merge 1 commit into from
Closed

Conversation

reidark
Copy link

@reidark reidark commented Jan 29, 2022

Reducing the aspect from pixelated (low resolution) favicon in New Tab.

I'm proposing this change after see some favicons as pixelated in "New Tab" from Brave.

After inspect it, I've realized that the size of the rendered favicon is 64px, but the style is forcing to scale up to 70px, giving the pixelated aspect.

I know that Brave use the chrome directory to get the visited favicons, and some favicons will be small no matter what, but I think this will reduce the impact.

Resolves brave/brave-browser#20784

Submitter Checklist:

  • I confirm that no security/privacy review is needed, or that I have requested one
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally: npm run test -- brave_browser_tests, npm run test -- brave_unit_tests, npm run lint, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

I'm proposing this change after see some favicons as "pixelated" in "New Tab" from Brave. 
After inspect it, I've realized that the size of the rendered favicon is 64px, but the style is forcing to scale up to 70px, giving the "pixelated" aspect.
I know that Brave use the chrome directory to get the visited favicons (as mentioned in brave-browser/brave#14485), and some favicons will be small no matter what, but I think this will reduce the impact.
@bsclifton
Copy link
Member

Closing as stale

@bsclifton bsclifton closed this Aug 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants