Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment pending message is showing up the incorrect BAT amount if there are any unreconciled ads in the previous month #20803

Closed
GeetaSarvadnya opened this issue Jan 31, 2022 · 1 comment · Fixed by brave/brave-core#12070

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jan 31, 2022

Description

Found while testing #16028

Payment pending message is showing the incorrect BAT amount if there are any unreconciled ads in the previous month

Steps to Reproduce

  1. Clean profile 1.35.x
  2. View a few Ads ( I have viewed 4 ads) today (31st Jan)
  3. Reconcile 2 ads with server and make sure another 2 ads are not reconciled
  4. Close the browser
  5. Set the system clock to 1st Feb 2022
  6. Relaunch the browser
  7. Payment pending message is showing up the BAT amount as 0.02 BAT instead of 0.01 BAT

Actual result:

Payment pending message is showing the incorrect BAT amount if there are any unreconciled ads in the previous month

image
image (10)

Expected result:

Payment pending message should show the BAT which is reconciled with the server

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.35.98 Chromium: 98.0.4758.74 (Official Build) (64-bit)
Revision d0fe1ec4df090cd3eb02b591228505e12ea476e9-refs/branch-heads/4758@{#935}
OS Windows 10 Version 21H2 (Build 19044.1466)

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Not sure

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Feb 1, 2022

Verification PASSED on

Brave | 1.35.99 Chromium: 98.0.4758.87 (Official Build) (64-bit)
-- | --
Revision | e4cd00f135fb4d8edc64c8aa6ecbe7cc79ebb3b2-refs/branch-heads/4758@{#1002}
OS | Windows 10 Version 21H2 (Build 19044.1466)

Broken profile

  • Launched the profile (where the issue was reproducible) with 1.35.99 and confirmed that the Payment pending message is showing up the correct reconciled BAT amount of 0.01 BAT
  • Confirmed previous month unreconciled ads BAT amount is carry forwarded to next month and shown in Ads panel Current earnings this month field
  • Confirmed Payment pending message starts showing up from 1st to 7th Feb and reconciled BAT is shown correctly
  • Confirmed Arrivinging message starts showing up from 8th to 11th Feb and reconciled BAT is shown correctly in arriving message
DB BAT amount in payment pending message BAT amount in arriving message
image image image

Clean profile - 1.35.99

  1. Clean profile 1.35.99 (Prod env)
  2. Viewed 4 NTP SI ads and 1 default ad notification
  3. Confirmed estimated rewards earnings and notification count is shown as expected
  4. Opened the DB and confirmed two 2 ads are reconciled with the server (0.05x2= 0.01 BAT)
  5. Confirmed 3 ads are not reconciled with the server in DB
  6. Closed the browser
  7. Set the system date to 1st March
  8. Relaunch the browser and reload the brave://rewards page
  9. Confirmed that the Payment pending message is showing up the correct reconciled BAT amount of 0.01 BAT
  10. Confirmed previous month unreconciled ads BAT amount is carry forwarded to next month and shown in Ads panel Current earnings this month field correctly
DB BAT amount in payment pending message BAT amount in arriving message
image image image (1)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment