Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disabling auto-contribution doesn't show YT publishers in Rewards panel #2084

Closed
kjozwiak opened this issue Nov 9, 2018 · 1 comment · Fixed by brave/brave-core#1336
Closed

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Nov 9, 2018

Description

YT channels will stop displaying under the Rewards panel when disabling auto-contribution. However, you can still tip to websites.

Steps to Reproduce

  1. launch 0.56.12 Chromium: 70.0.3538.77 and enable rewards via brave://rewards
  2. once rewards has been enabled, disable auto-contribution
  3. visit youtube.com and click on any random channels on the front page
  4. click on the Reward panel via the BAT icon and you'll notice you'll see the summary but no tipping information for that particular channel

Actual result:

yttipping

Expected result:

Even though auto-contribution has been disabled, you should still be able to see specific YT channels within the Rewards panel when clicking on the BAT icon.

Reproduces how often:

100% reproducible using the above STR.

Brave version (brave://version info)

Brave 0.56.12 Chromium: 70.0.3538.77 (Official Build) (64-bit)
Revision 0f6ce0b0cd63a12cb4eccea3637b1bc9a29148d9-refs/branch-heads/3538@{#1039}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Checking other channels, will update with more information.

@kjozwiak kjozwiak added this to the 0.56.x - Release Hotfix 1 milestone Nov 9, 2018
@kjozwiak kjozwiak added this to Untriaged Backlog in Rewards via automation Nov 9, 2018
@kjozwiak kjozwiak modified the milestones: 0.56.x - Release Hotfix 1, 1.0, 1.x Backlog Nov 12, 2018
@kjozwiak kjozwiak added the priority/P2 A bad problem. We might uplift this to the next planned release. label Nov 12, 2018
@NejcZdovc NejcZdovc moved this from Untriaged Backlog to P1 & P2 Backlog in Rewards Nov 12, 2018
@NejcZdovc NejcZdovc self-assigned this Nov 13, 2018
@NejcZdovc NejcZdovc moved this from P1 & P2 Backlog to In Progress in Rewards Nov 22, 2018
@NejcZdovc NejcZdovc moved this from In Progress to Pending review in Rewards Nov 26, 2018
@NejcZdovc NejcZdovc added this to Nejc in Rewards Team Dec 3, 2018
@NejcZdovc NejcZdovc removed the blocked label Dec 18, 2018
@NejcZdovc NejcZdovc moved this from Pending review to In Progress in Rewards Jan 4, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 14, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 14, 2019
@NejcZdovc NejcZdovc moved this from In Progress to Pending review in Rewards Jan 14, 2019
Rewards automation moved this from Pending review to Completed Jan 14, 2019
Rewards Team automation moved this from Nejc to Closed Jan 14, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.60.x - Dev Jan 14, 2019
@btlechowski
Copy link

btlechowski commented Jan 17, 2019

Verification passed on

Brave 0.59.25 Chromium: 72.0.3626.53 (Official Build) beta (64-bit)
Revision 98434e6cd182d68ce396daa92e9c6310422e6763-refs/branch-heads/3626@{#620}
OS Windows 7

Used test plan from brave/brave-core#1336

Verification passed on

Brave 0.59.26 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Linux

Verification PASSED on macOS 10.14.2 x64 using the following build:

Brave 0.59.28 Chromium: 72.0.3626.64 (Official Build) beta(64-bit)
Revision eaa9668e80ce5405e7f1902579558ea725c06ca1-refs/branch-heads/3626@{#708}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants