Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop Crypto Wallet extension if default wallet is set to a different wallet #20905

Closed
bbondy opened this issue Feb 5, 2022 · 1 comment · Fixed by brave/brave-core#12178
Closed

Stop Crypto Wallet extension if default wallet is set to a different wallet #20905

bbondy opened this issue Feb 5, 2022 · 1 comment · Fixed by brave/brave-core#12178
Assignees
@spylogsster
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.36.x - Release

Comments

@bbondy
Copy link
Member

bbondy commented Feb 5, 2022 •
edited by spylogsster
Loading

The setting only requires a new tab but it’s safest to restart after because if for example you have the crypto wallets extension loaded then it doesn’t close down until you restart and that can cause problems. We should just prompt to restart I agree.

Update: In slack discussed if crypto wallets extension is started, it would need to be stopped when setting is not set to crypto wallets.
@bbondy bbondy added feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop labels Feb 5, 2022
@bbondy bbondy added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 7, 2022
@spylogsster spylogsster self-assigned this Feb 7, 2022
@spylogsster spylogsster mentioned this issue Feb 8, 2022
Merged
25 tasks
@spylogsster spylogsster changed the title Prompt to restart when default wallet pref is changed Stop Crypto Wallet extension if user selected native Brave Wallet Feb 9, 2022
@spylogsster spylogsster added this to the 1.37.x - Nightly milestone Feb 10, 2022
@brave-builds brave-builds mentioned this issue Feb 10, 2022
Merged
7 tasks
@srirambv
Copy link
Contributor

Brave 1.36.100 Chromium: 98.0.4758.102 (Official Build) beta (64-bit)
Revision 273bf7ac8c909cde36982d27f66f3c70846a3718-refs/branch-heads/4758@{#1151}
OS ☑️ Linux ☑️ Windows 11 Version Dev
(Build 22523.1000) 		☑️ macOS Version 12.0.1
(Build 21C52)
  • Verified steps from brave/brave-core#12178
  • Verified when default wallet provider is changed to Brave Wallet or Brave Wallet (Prefer Extensions), ERC Wallet extension is disabled
  • Verified changing back to Deprecated wallet doesn't start automatically, need to enable the extension manually
20905-Linux.mp4
20905-Windows.mov
20905-macOS.mov

@bbondy bbondy changed the title Stop Crypto Wallet extension if user selected native Brave Wallet Stop Crypto Wallet extension if default wallet is set to a different wallet Mar 1, 2022
@LaurenWags LaurenWags mentioned this issue Mar 1, 2022
Closed
@kjozwiak kjozwiak mentioned this issue Mar 14, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spylogsster spylogsster

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.36.x - Release
Development

Successfully merging a pull request may close this issue.

Stop Crypto Wallet extension if user selected other options brave/brave-core
4 participants
@bbondy @kjozwiak @spylogsster @srirambv