Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disable tracing crash uploader default endpoints #2121

Closed
pilgrim-brave opened this issue Nov 13, 2018 · 0 comments · Fixed by brave/brave-core#900
Closed

Disable tracing crash uploader default endpoints #2121

pilgrim-brave opened this issue Nov 13, 2018 · 0 comments · Fixed by brave/brave-core#900
Assignees
@pilgrim-brave
Labels
privacy/connect This requires making a network connection to a third-party service. QA/No release-notes/exclude
Projects
Network Audit
Milestone
0.59.x - Release ...

Comments

@pilgrim-brave
Copy link

pilgrim-brave commented Nov 13, 2018 •
edited
Loading

about:tracing has options to upload trace crash logs to an endpoint which, by default, is a Google-owned server. You can override the endpoint in 2 different ways:

  1. In brave://flags#trace-upload-url you can select a "tag" which changes the endpoint to a URL specified in chrome/browser/about_flags.cc (all options are Google-owned)
  2. On the command line, you can specify an arbitrary endpoint with the --trace-upload-url flag

We should keep the command line feature available for power users, but we should disable all the default endpoints or point them to Brave-controlled servers.
@pilgrim-brave pilgrim-brave self-assigned this Nov 13, 2018
@pilgrim-brave pilgrim-brave added the privacy/connect This requires making a network connection to a third-party service. label Nov 13, 2018
@pilgrim-brave pilgrim-brave added this to the 1.x Backlog milestone Nov 13, 2018
pilgrim-brave added a commit to brave/brave-core that referenced this issue Nov 13, 2018
@pilgrim-brave
Disable default endpoints for trace upload URL
b1db2c7 
Fixes brave/brave-browser#2121
@pilgrim-brave pilgrim-brave mentioned this issue Nov 13, 2018
Merged
18 tasks
@pilgrim-brave pilgrim-brave added this to In Progress in Network Audit Nov 14, 2018
@pilgrim-brave pilgrim-brave moved this from In Progress to Pending review in Network Audit Nov 14, 2018
Network Audit automation moved this from Pending review to Completed Nov 15, 2018
@pilgrim-brave pilgrim-brave modified the milestones: 1.x Backlog, 0.59.x - Nightly Nov 15, 2018
@paulirish paulirish mentioned this issue Jun 4, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@pilgrim-brave pilgrim-brave

Labels
privacy/connect This requires making a network connection to a third-party service. QA/No release-notes/exclude
Projects
No open projects
Network Audit
  
Completed
Milestone
0.59.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Disable default endpoints for trace upload URL brave/brave-core
2 participants
@bbondy @pilgrim-brave