Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need space between blocked count and Trackers & ads in Shields panel #22012

Closed
stephendonner opened this issue Mar 31, 2022 · 2 comments · Fixed by brave/brave-core#12885 or brave/brave-core#12894

Comments

@stephendonner
Copy link

Description

Need space between blocked count and Trackers & ads in Shields panel

Steps to Reproduce

  1. install 1.39.18
  2. launch Brave
  3. load a high-tracker-count website and/or be patient
  4. get at least 100 trackers (I think; I had 300+ in this tab's session)
  5. click on the Brave Shields icon in the URL bar
  6. click to expand the Advanced Controls section of the panel
  7. click on the 99+ for the first option, Aggressively block trackers & ads

Actual result:

Screen Shot 2022-03-31 at 1 27 50 AM

Expected result:

A space in-between 306 and Trackers & ads

Reproduces how often:

Not 100% for me yet

Brave version (brave://version info)

Brave 1.39.18 Chromium: 100.0.4896.60 (Official Build) nightly (x86_64)
Revision 6a5d10861ce8de5fce22564658033b43cb7de047-refs/branch-heads/4896@{#875}
OS macOS Version 12.3 (Build 21E230)

cc @nullhook @Tonev

@kjozwiak
Copy link
Member

kjozwiak commented Apr 8, 2022

Above requires 1.38.85 or higher for 1.38.x verification.

@stephendonner
Copy link
Author

Verified PASSED using

Brave 1.38.88 Chromium: 100.0.4896.79 (Official Build) beta (x86_64)
Revision 8fb749dcab8700c24213791969e59deb72fee36f-refs/branch-heads/4896@{#1015}
OS macOS Version 11.6.5 (Build 20G527)

Confirmed for 100+ (and <1,000) values.

light mode

100+ 1,000+
Screen Shot 2022-04-11 at 10 47 46 PM Screen Shot 2022-04-11 at 5 13 08 PM

dark mode

100+ 1,000+
Screen Shot 2022-04-11 at 10 47 06 PM Screen Shot 2022-04-11 at 7 13 22 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants