Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

expand icon under brave shields using incorrect colour when Privacy Report enabled #22049

Closed
kjozwiak opened this issue Apr 2, 2022 · 1 comment · Fixed by brave/brave-core#12875
Assignees
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include

Comments

@kjozwiak
Copy link
Member

kjozwiak commented Apr 2, 2022

Description

The -> icon appears to be using the incorrect colour scheme under Brave Shields when Privacy Report has been enabled.

Steps to reproduce

  1. launch Brave and enabled Privacy Report via onboarding
  2. once enabled, visit any website and expand the shields panel
  3. notice that the -> button looks ping rather than the correct colour

Actual result

image

Expected result

image

Issue reproduces how often

100% reproducible using the STR/Cases outlined above.

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

1.37.110 Chromium 100.0.4896.60

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? N/A
  • Does the issue resolve itself when disabling Brave Rewards? N/A
  • Is the issue reproducible on the latest version of Chrome? N/A

Additional information

CCing @anthonypkeane @SergeyZhukovsky @Uni-verse @srirambv

@kjozwiak kjozwiak added bug QA/Yes feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality labels Apr 2, 2022
@kjozwiak kjozwiak added this to Backlog in Android General via automation Apr 2, 2022
@samartnik samartnik self-assigned this Apr 4, 2022
Android General automation moved this from Backlog to Done/Closed Apr 4, 2022
@samartnik samartnik added this to the 1.39.x - Nightly milestone Apr 4, 2022
@kjozwiak
Copy link
Member Author

Verification PASSED on Samsung S10+ running Android 12 using the following build(s):

Brave | 1.39.109 Chromium: 102.0.5005.50 (Official Build) (64-bit)
--- | ---
Revision | f6e2cf8f59ec714bdcff8499991d55898875f287-refs/branch-heads/5005@{#648}
OS | Android 11; Build/RP1A.200720.012

Went through the STR/Cases outlined via #22049 (comment) and ensured that the -> button is appearing correctly under Brave Shields as per the following:

1.38.113 Chromium: 101.0.4951.61 (Broken) 1.39.109 (Fixed) 1.39.109 (Fixed)
Screenshot_20220519-170100_Brave Screenshot_20220519-165108_Brave Screenshot_20220519-170438_Brave

avinassh pushed a commit to avinassh/brave-browser-hardening that referenced this issue May 29, 2022
 - Added Brave Firewall + VPN. ([#12197](brave/brave-browser#12197))
 - Added support for blob partitioning. ([#21746](brave/brave-browser#21746))
 - Implemented eth_getEncryptionPublicKey for Brave Wallet. ([#19276](brave/brave-browser#19276))
 - Reduced adblock filter memory usage by optimizing unused regex rules. ([#21970](brave/brave-browser#21970))
 - Removed known Dialog Insight user tracking parameters from URLs. ([#22082](brave/brave-browser#22082))
 - Fixed breakage in webpack build caused by OpenSSL 3.0. ([#22305](brave/brave-browser#22305))
 - Fixed pending bell icon under Brave Wallet not being displayed when new unapproved requests are created. ([#21654](brave/brave-browser#21654))
 - Fixed expand icon under Brave Shields using incorrect color when the Privacy Hub has been enabled. ([#22049](brave/brave-browser#22049))
 - Upgraded Chromium to 102.0.5005.61. ([#22923](brave/brave-browser#22923)) ([Changelog for 102.0.5005.61](https://chromium.googlesource.com/chromium/src/+log/101.0.4951.67..102.0.5005.61?pretty=fuller&n=1000))
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/shields/panel Front-end design and functionality of the Shields panel. OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
Android General
  
Done/Closed
Development

Successfully merging a pull request may close this issue.

2 participants