Update webpack to v5 (or later) #22351

petemill · 2022-04-15T18:06:31Z

Webpack 4 is now becoming quite legacy and 5 is pretty mature, offering more configuration and some potential performance benefits.

Actions:

...
Remove workaround introduced in webpack: Replace md4 hash with 256-bit sha2. brave-core#13021

mihaiplesa · 2022-11-09T10:16:21Z

This is biting us hard now. Anything we can do to upgrade webpack?

nodejs/node#40455
storybookjs/storybook#19692

[2022-11-09T09:29:03.750Z] <s> [webpack.Progress] 10% building 1/4 modules 3 active /Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/node_modules/babel-loader/lib/index.js??ref--4-0!/Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/.storybook/preview.js-generated-config-entry.js

[2022-11-09T09:29:04.067Z] node:internal/crypto/hash:71

[2022-11-09T09:29:04.067Z]   this[kHandle] = new _Hash(algorithm, xofLen);

[2022-11-09T09:29:04.067Z]                   ^

[2022-11-09T09:29:04.067Z] 

[2022-11-09T09:29:04.067Z] Error: error:0308010C:digital envelope routines::unsupported

[2022-11-09T09:29:04.067Z]     at new Hash (node:internal/crypto/hash:71:19)

[2022-11-09T09:29:04.067Z]     at Object.createHash (node:crypto:133:10)

[2022-11-09T09:29:04.067Z]     at module.exports (/Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/node_modules/webpack/lib/util/createHash.js:135:53)

[2022-11-09T09:29:04.067Z]     at NormalModule._initBuildHash (/Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/node_modules/webpack/lib/NormalModule.js:417:16)

[2022-11-09T09:29:04.068Z]     at handleParseError (/Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/node_modules/webpack/lib/NormalModule.js:471:10)

[2022-11-09T09:29:04.068Z]     at /Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/node_modules/webpack/lib/NormalModule.js:503:5

[2022-11-09T09:29:04.068Z]     at /Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/node_modules/webpack/lib/NormalModule.js:358:12

[2022-11-09T09:29:04.068Z]     at /Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/node_modules/loader-runner/lib/LoaderRunner.js:373:3

[2022-11-09T09:29:04.068Z]     at iterateNormalLoaders (/Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/node_modules/loader-runner/lib/LoaderRunner.js:214:10)

[2022-11-09T09:29:04.069Z]     at iterateNormalLoaders (/Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/node_modules/loader-runner/lib/LoaderRunner.js:221:10)

[2022-11-09T09:29:04.069Z]     at /Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/node_modules/loader-runner/lib/LoaderRunner.js:236:3

[2022-11-09T09:29:04.069Z]     at context.callback (/Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/node_modules/loader-runner/lib/LoaderRunner.js:111:13)

[2022-11-09T09:29:04.069Z]     at /Users/jenkins/jenkins/workspace/pr-brave-browser-fix-compiledb-patch-macos/src/brave/node_modules/babel-loader/lib/index.js:59:71 {

[2022-11-09T09:29:04.069Z]   opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],

[2022-11-09T09:29:04.069Z]   library: 'digital envelope routines',

[2022-11-09T09:29:04.069Z]   reason: 'unsupported',

[2022-11-09T09:29:04.069Z]   code: 'ERR_OSSL_EVP_UNSUPPORTED'

[2022-11-09T09:29:04.069Z] }

[2022-11-09T09:29:04.069Z] 

[2022-11-09T09:29:04.069Z] Node.js v18.12.1

stephendonner · 2023-12-07T18:29:53Z

Verification `PASSED` using

Brave | 1.63.24 Chromium: 120.0.6099.71 (Official Build) nightly (64-bit)
-- | --
Revision | 8858c508f9a33d9cb69c2b3f2da81a52a15040f6
OS | Windows 10 Version 22H2 (Build 19045.3758)

WebTorrent

`torrent`	`magnet`

New-tab page

`Sponsored Image`	regular tab/customize dialog

Brave Rewards

`logged out`	`custodian-connected`

Logged:

Promo-card images (Creator, Tap) are missing from brave://rewards #34775

Brave Wallet

`default view`	`recovery phrase`	`recovery-phrase matching`	`Portfolio`

Brave Shields

`Shields up`, collapsed	`Shields up`, expanded	`Shields down`

`Leo` AI chat

`onboarding`	`defaults`	`summarize`	`questions`	`settings overlay`

Shortcuts

example	example	example	example

kjozwiak · 2023-12-18T04:13:45Z

Removing the QA Pass label as the above needs to be re-verified/checked on 1.62.x now that it was uplifted via brave/brave-core#21380. Used #22351 (comment) as the verification needed for uplift 👍

kjozwiak · 2023-12-18T04:14:11Z

The above requires 1.62.113 or higher for 1.62.x verification 👍

btlechowski · 2023-12-28T12:54:53Z

Verified with

Brave	1.62.122 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
Revision	cfddebe77d394064c472fda64afcd9fbed34ceb4
OS	Linux

Verified using #22351 (comment)

WebTorrent

`torrent`	`magnet`

New-tab page

`Sponsored Image`	regular tab/customize dialog

Brave Rewards

`logged out`	`custodian-loggedout`

Encountered:

Promo-card images (Creator, Tap) are missing from brave://rewards #34775

Brave Wallet

Brave Shields

`Shields up`, collapsed	`Shields up`, expanded	`Shields down`

`Leo` AI chat

`onboarding`	`defaults`	`summarize`	`questions`	`settings overlay`

Shortcuts

example	example	example

LaurenWags · 2023-12-28T18:33:51Z

Verified with

Brave | 1.62.123 Chromium: 120.0.6099.144 (Official Build) beta (x86_64)
-- | --
Revision | 680382264ff6ae655b3bba25e80567452f38fbee
OS | macOS Version 13.6.3 (Build 22G436)

Verified using test cases from #22351 (comment)

WebTorrent

Note, theme issues are existing and were previously reported with #33524.

`torrent`	`magnet`

New-tab page

`Sponsored Image`	regular tab/customize dialog

Brave Rewards

Encountered #34775.

`Custodian not connected`	`Custodian connected`	`Custodian logged out`

Brave Wallet

Brave Shields

`Shields up`, collapsed	`Shields up`, expanded	`Shields down`

`Leo` AI chat

`initial screen`	`onboarding`	`summarize`	`questions`	`settings overlay`

Shortcuts

example	example	example	example

GeetaSarvadnya · 2023-12-29T05:15:01Z

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.62.121

Verified using test cases from #22351 (comment)

WebTorrent

Note: Click on torrent or magnet link via https://webtorrent.io/free-torrents download the .torrent file there is no UI to see the Files, Start torrent and Save torrent files

New-tab page

`Sponsored Image`	regular tab/customize dialog

Brave Rewards

`Custodian not connected`	`Custodian connected`	`Custodian logged out`

Brave Wallet

Example	Example	Example

Brave Shields

`Shields up`, collapsed	`Shields up`, expanded	`Shields down`

`Leo` AI chat

`initial screen`	`onboarding`	`summarize`	`questions`	`settings overlay`

MadhaviSeelam · 2024-01-03T00:35:01Z

Verification PASSED using

Brave | 1.62.128 Chromium: 120.0.6099.144 (Official Build) beta (64-bit)
-- | --
Revision | 41f5844c06c7db1017f39b5b6dc9ba81a6b1b9d6
OS | Windows 11 Version 22H2 (Build 22621.2861)

WebTorrent

`torrent`	`magnet`

New-tab page

`Sponsored Image`	regular tab/customize dialog

`Brave Rewards`

Custodian not connected	Custodian connected	Custodian logged out

`Brave Wallet`

example	example	example	example

Brave Shields

`Shields up`, collapsed	`Shields up`, expanded	`Shields down`

`Leo` AI chat

`onboarding`	`defaults`	`summarize`	`questions`	`settings overlay`

`Shortcuts`

example	example	example	example

Uni-verse · 2024-01-19T21:27:19Z

Verified on Samsung Galaxy Tab S7 using version:

Brave	1.62.147 Chromium: 120.0.6099.234 (Official Build) (32-bit) 
Revision	3b25c3743150a54485dea24f0ceb1e69d6db51bc
OS	Android 13; Build/TP1A.220624.014; 33; REL

Test Plan: #22351 (comment)

Web Torrent

New Tab Page

Example	Example

Brave Rewards

Brave Wallet

Example	Example	Example

Brave Shields

Example	Example	Example

Leo

Example	Example	Example	Example

petemill added web-ui OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 15, 2022

petemill self-assigned this Apr 15, 2022

rebron added this to Untriaged backlog in Front End Apr 26, 2022

mihaiplesa added this to Backlog in CI concerns via automation Nov 9, 2022

petemill mentioned this issue Dec 9, 2022

Update webpack, webpack-cli and associated plugins and loaders to latest webpack-v4-supporting versions brave/brave-core#16317

Closed

25 tasks

This was referenced Nov 8, 2023

Don't run postInstall scripts #28419

Open

audit and sandbox npm dependencies in brave wallet UI #20724

Open

fallaciousreasoning mentioned this issue Nov 16, 2023

[Dependencies]: Upgrade to Webpack 5 brave/brave-core#21003

Merged

25 tasks

fallaciousreasoning closed this as completed in brave/brave-core#21003 Dec 3, 2023

CI concerns automation moved this from Backlog to Done Dec 3, 2023

brave-builds added this to the 1.63.x - Nightly milestone Dec 3, 2023

fallaciousreasoning added QA/Yes release-notes/exclude labels Dec 4, 2023

stephendonner mentioned this issue Dec 7, 2023

Promo-card images (Creator, Tap) are missing from brave://rewards #34775

Closed

stephendonner added the QA Pass-Win64 label Dec 7, 2023

fallaciousreasoning mentioned this issue Dec 14, 2023

[Uplift 1.62.x] [Nala]: Update to latest brave/brave-core#21380

Merged

kjozwiak moved this from Untriaged backlog to Completed in Front End Dec 18, 2023

kjozwiak added the QA/Test-All-Platforms label Dec 18, 2023

brave-builds modified the milestones: 1.63.x - Nightly, 1.62.x - Beta Dec 18, 2023

kjozwiak removed the QA Pass-Win64 label Dec 18, 2023

btlechowski added the QA Pass-Linux label Dec 28, 2023

GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 28, 2023

LaurenWags added the QA Pass-macOS label Dec 28, 2023

MadhaviSeelam added the QA Pass-Win64 label Jan 3, 2024

GeetaSarvadnya added QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 8, 2024

Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jan 19, 2024

Uni-verse added QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jan 19, 2024

rebron removed this from Completed in Front End Jan 26, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update webpack to v5 (or later) #22351

Update webpack to v5 (or later) #22351

petemill commented Apr 15, 2022

mihaiplesa commented Nov 9, 2022

stephendonner commented Dec 7, 2023 •

edited

Loading

kjozwiak commented Dec 18, 2023

kjozwiak commented Dec 18, 2023

btlechowski commented Dec 28, 2023

LaurenWags commented Dec 28, 2023 •

edited

Loading

GeetaSarvadnya commented Dec 29, 2023 •

edited

Loading

MadhaviSeelam commented Jan 3, 2024 •

edited

Loading

Uni-verse commented Jan 19, 2024 •

edited

Loading

Update webpack to v5 (or later) #22351

Update webpack to v5 (or later) #22351

Comments

petemill commented Apr 15, 2022

mihaiplesa commented Nov 9, 2022

stephendonner commented Dec 7, 2023 • edited Loading

Verification PASSED using

WebTorrent

New-tab page

Brave Rewards

Brave Wallet

Brave Shields

Leo AI chat

Shortcuts

kjozwiak commented Dec 18, 2023

kjozwiak commented Dec 18, 2023

btlechowski commented Dec 28, 2023

WebTorrent

New-tab page

Brave Rewards

Brave Wallet

Brave Shields

Leo AI chat

Shortcuts

LaurenWags commented Dec 28, 2023 • edited Loading

WebTorrent

New-tab page

Brave Rewards

Brave Wallet

Brave Shields

Leo AI chat

Shortcuts

GeetaSarvadnya commented Dec 29, 2023 • edited Loading

WebTorrent

New-tab page

Brave Rewards

Brave Wallet

Brave Shields

Leo AI chat

MadhaviSeelam commented Jan 3, 2024 • edited Loading

WebTorrent

New-tab page

Brave Rewards

Brave Wallet

Brave Shields

Leo AI chat

Shortcuts

Uni-verse commented Jan 19, 2024 • edited Loading

stephendonner commented Dec 7, 2023 •

edited

Loading

Verification `PASSED` using

`Leo` AI chat

`Leo` AI chat

LaurenWags commented Dec 28, 2023 •

edited

Loading

`Leo` AI chat

GeetaSarvadnya commented Dec 29, 2023 •

edited

Loading

`Leo` AI chat

MadhaviSeelam commented Jan 3, 2024 •

edited

Loading

`Brave Rewards`

`Brave Wallet`

`Leo` AI chat

`Shortcuts`

Uni-verse commented Jan 19, 2024 •

edited

Loading