Join GitHub today
GitHub is home to over 50 million developers working together to host and review code, manage projects, and build software together.
Sign upMonthly Contribution Dropdown in Wallet Panel should retain value #2245
Labels
Projects
Milestone
Comments
|
Hope we can land this before |
|
Reverted due to failing unit tests, re-opening. |
ryanml
added a commit
to ryanml/brave-core
that referenced
this issue
Mar 21, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
ryanml
added a commit
to ryanml/brave-core
that referenced
this issue
Mar 24, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
NejcZdovc
added a commit
to ryanml/brave-core
that referenced
this issue
Mar 25, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
ryanml
added a commit
to brave/brave-core
that referenced
this issue
Mar 26, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
ryanml
added a commit
to brave/brave-core
that referenced
this issue
Mar 28, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
ryanml
added a commit
to brave/brave-core
that referenced
this issue
Mar 28, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
ryanml
added a commit
to brave/brave-core
that referenced
this issue
Apr 1, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
ryanml
added a commit
to brave/brave-core
that referenced
this issue
Apr 2, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
ryanml
added a commit
to brave/brave-core
that referenced
this issue
Apr 5, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Apr 8, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
NejcZdovc
added a commit
to brave/brave-core
that referenced
this issue
Apr 8, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
pilgrim-brave
added a commit
to brave/brave-core
that referenced
this issue
Apr 16, 2019
Fixes brave/brave-browser#2823 Monthly donation functionality via panel
This was referenced May 10, 2019
|
Verification passed on
Verification passed on
Verified passed with
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
This should call the functions
SaveRecurringDonationandRemoveRecurring. The former should called when a non-0 value is set, and the latter when 0 is set.Description
Steps to Reproduce
brave.comActual result:
New value is not returned, is 0.0
Expected result:
Dropdown should be 5.0
Reproduces how often:
Brave version (brave://version info)
Reproducible on current release:
Website problems only:
Additional Information