Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Monthly Contribution Dropdown in Wallet Panel should retain value #2245

Closed
ryanml opened this issue Nov 27, 2018 · 3 comments · Fixed by brave/brave-core#957 or brave/brave-core#2069
Closed

Comments

@ryanml
Copy link
Contributor

ryanml commented Nov 27, 2018

This should call the functions SaveRecurringDonation and RemoveRecurring. The former should called when a non-0 value is set, and the latter when 0 is set.

Description

Steps to Reproduce

  1. Enable Brave Rewards
  2. Navigate to a site such as brave.com
  3. Bring up the wallet panel.
  4. Change monthly contribution amount to '5.0'
  5. Close and re-open panel

Actual result:

New value is not returned, is 0.0

Expected result:

Dropdown should be 5.0

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

@ryanml ryanml self-assigned this Nov 27, 2018
ryanml added a commit to ryanml/brave-core that referenced this issue Nov 27, 2018
@NejcZdovc NejcZdovc added this to Untriaged Backlog in Rewards via automation Nov 27, 2018
ryanml added a commit to ryanml/brave-core that referenced this issue Nov 27, 2018
ryanml added a commit to ryanml/brave-core that referenced this issue Nov 27, 2018
ryanml added a commit to ryanml/brave-core that referenced this issue Nov 28, 2018
ryanml added a commit to ryanml/brave-core that referenced this issue Nov 28, 2018
@kjozwiak
Copy link
Member

Hope we can land this before 0.58.x moves into beta or this will need to get uplifted 👍

ryanml added a commit to ryanml/brave-core that referenced this issue Nov 29, 2018
ryanml added a commit to ryanml/brave-core that referenced this issue Nov 30, 2018
@bbondy bbondy added this to the 1.x Backlog milestone Dec 2, 2018
ryanml added a commit to ryanml/brave-core that referenced this issue Dec 3, 2018
@NejcZdovc NejcZdovc moved this from Untriaged Backlog to In Progress in Rewards Dec 3, 2018
Rewards automation moved this from In Progress to Completed Dec 3, 2018
@bbondy
Copy link
Member

bbondy commented Dec 4, 2018

Reverted due to failing unit tests, re-opening.
brave/brave-core@f77acbe

@bbondy bbondy reopened this Dec 4, 2018
Rewards automation moved this from Completed to In Progress Dec 4, 2018
ryanml added a commit to ryanml/brave-core that referenced this issue Dec 4, 2018
Rewards automation moved this from In Progress to Completed Dec 4, 2018
@NejcZdovc NejcZdovc reopened this Dec 4, 2018
Rewards automation moved this from Completed to In Progress Dec 4, 2018
@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label Dec 6, 2018
@NejcZdovc NejcZdovc moved this from In Progress to P3, P4, & P5 Backlog in Rewards Dec 6, 2018
ryanml added a commit to ryanml/brave-core that referenced this issue Mar 21, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
ryanml added a commit to ryanml/brave-core that referenced this issue Mar 24, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
NejcZdovc pushed a commit to ryanml/brave-core that referenced this issue Mar 25, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
ryanml added a commit to brave/brave-core that referenced this issue Mar 26, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
ryanml added a commit to brave/brave-core that referenced this issue Mar 28, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
ryanml added a commit to brave/brave-core that referenced this issue Mar 28, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
ryanml added a commit to brave/brave-core that referenced this issue Apr 1, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
@NejcZdovc NejcZdovc moved this from Pending review to In Progress in Rewards Apr 2, 2019
ryanml added a commit to brave/brave-core that referenced this issue Apr 2, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
@NejcZdovc NejcZdovc moved this from In Progress to Pending review in Rewards Apr 4, 2019
ryanml added a commit to brave/brave-core that referenced this issue Apr 5, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Apr 8, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Apr 8, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
@ryanml ryanml added the QA/Yes label Apr 8, 2019
Rewards automation moved this from Pending review to Completed Apr 8, 2019
Rewards Team automation moved this from Ryan to Closed Apr 8, 2019
pilgrim-brave pushed a commit to brave/brave-core that referenced this issue Apr 16, 2019
Fixes brave/brave-browser#2823

Monthly donation functionality via panel
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 15, 2019

Verification passed on

Brave 0.65.93 Chromium: 74.0.3729.131 (Official Build) beta (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Windows 10 OS Build 17134.523

Verification passed on

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Ubuntu 18.04 LTS

Verified passed with

Brave 0.65.97 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment