Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wallet auto-lock doesn't hide ApproveTxBottomSheetDialog #23049

Closed
wchen342 opened this issue May 25, 2022 · 3 comments · Fixed by brave/brave-core#19178
Closed

Wallet auto-lock doesn't hide ApproveTxBottomSheetDialog #23049

wchen342 opened this issue May 25, 2022 · 3 comments · Fixed by brave/brave-core#19178
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@wchen342
Copy link

wchen342 commented May 25, 2022 •
edited

Description

Approve tx bottom sheet is not hidden when wallet is auto-locked.

Steps to reproduce

  1. Unlock wallet, init a transaction but do not approve or reject.
  2. Go back to portfolio screen.
  3. Click on the bell icon to bring up the bottom sheet.
  4. Wait for auto-lock.
  5. The bottom sheet is not hidden when wallet is locked.

Version/Channel Information:

Nightly
@wchen342 wchen342 added QA/Yes feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels May 25, 2022
@srirambv
Copy link
Contributor

srirambv commented May 25, 2022 •
edited

Unable to repro it with or without fingerprint enabled

Edit: Able to repro with the updated steps

@wchen342
Copy link
Author

Updated with extra steps.

@jamesmudgett jamesmudgett added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jun 7, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Jun 26, 2023
Closed
@Pavneet-Sing Pavneet-Sing self-assigned this Jun 26, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Jul 6, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.58.x - Nightly milestone Jul 7, 2023
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.58.117 x64 build

  • Verified steps from brave/brave-core#19178
  • Verified wallet autolock dismisses the pending transaction approval screen
23049.mp4

This was referenced Sep 15, 2023
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Hide tx,BSS dialogs when wallet is auto-locked brave/brave-core
6 participants
@jamesmudgett @kjozwiak @wchen342 @Pavneet-Sing @srirambv @brave-builds