Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Wallet UI components stay visible after Wallet was locked #31272

Closed
stoletheminerals opened this issue Jun 23, 2023 · 4 comments · Fixed by brave/brave-core#19178
Closed
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include security

Comments

@stoletheminerals
Copy link

stoletheminerals commented Jun 23, 2023

Description

Once Wallet was automatically locked on time-out, transaction details screen stays visible on top of the passcode screen

Steps to reproduce

  1. Go to Wallet settings and change autolock timeout to 1 minute (not required, just easier to test)
  2. Go to Activity screen in Wallet and press on any transaction to pop-up the transaction details screen
  3. Wait until Wallet is auto locked on time out

Actual result

Transaction details screen stays visible on top of the passcode screen.

image

Expected result

Transaction details screen should be hidden

Issue reproduces how often

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version?
  • Can you reproduce this issue with the current Play Store Beta version?
  • Can you reproduce this issue with the current Play Store Nightly version?

Device details

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Brave version

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@stoletheminerals stoletheminerals added bug security feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jun 23, 2023
@stoletheminerals
Copy link
Author

cc @Pavneet-Sing @simoarpe

@stoletheminerals stoletheminerals changed the title [Android] Transaction details screen stays visible after Wallet was locked [Android] Wallet UI components stay visible after Wallet was locked Jun 23, 2023
@stoletheminerals
Copy link
Author

This menu also stays on top and allows me to press Send and proceed up to the Approve screen. Approve button doesn't work since the wallet is locked and the private key is not available, but an attacker can check Wallet balances on all available networks
image

@stoletheminerals stoletheminerals added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jun 23, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Jun 26, 2023
@Pavneet-Sing
Copy link

Mirror issue: #23049

@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 13 running 1.58.117 x64 build

  • Verified steps from brave/brave-core#19178
  • Verified wallet autolock dismisses the transaction details screen
31272.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include security
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

4 participants