Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Add an explicit "Block connections without VPN" setting to VPN (VPN kill switch) #23193

Closed
bsclifton opened this issue Jun 1, 2022 · 8 comments · Fixed by brave/brave-core#23293
Assignees
Labels
feature/vpn feature-request OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. privacy/discussed Discussed in privacy confab privacy/feature User-facing privacy- & security-focused feature work. QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@bsclifton
Copy link
Member

Description

When users purchase and use VPN on Android, a new connection will be created by the OS for the VPN (w/ hostname/user/pass)

When visiting in settings, you can enable Always on functionality which should force a reconnection if service is lost. We could offer a new setting (screenshot below has for reference) where we can block any outbound traffic on the device when the VPN is not used. Here's an example from Express VPN:
image

This is useful so that DNS or other info isn't leaked if the VPN connection is unintentionally dropped

cc: @mattmcalister

@bsclifton bsclifton added privacy/feature User-facing privacy- & security-focused feature work. feature-request OS/Android Fixes related to Android browser functionality feature/vpn labels Jun 1, 2022
@bsclifton bsclifton added this to Backlog in Android General via automation Jun 1, 2022
@mattmcalister
Copy link

is this is a device-wide setting?

@ShivanKaul ShivanKaul added the privacy/discussed Discussed in privacy confab label Jun 21, 2022
@bsclifton bsclifton changed the title Add an explicit "Block connections without VPN" setting to VPN Add an explicit "Block connections without VPN" setting to VPN (VPN kill switch) Feb 6, 2023
@bsclifton
Copy link
Member Author

@mattmcalister yes it is

Looks like our VPN is already showing this unfortunately (and it doesn't work). See https://twitter.com/Maxdani99970966/status/1622043555362398209 for the report
image

@bsclifton bsclifton added the priority/P3 The next thing for us to work on. It'll ride the trains. label Feb 6, 2023
@bsclifton bsclifton moved this from Backlog to P3 in Android General Feb 6, 2023
@bsclifton bsclifton added this to Untriaged backlog in VPN Mar 30, 2023
@deeppandya
Copy link

@bsclifton @mattmcalister i checked with latest release. if you have Block connections without VPN selected and turn off the vpn connection, it stops the connections from all other apps except Brave as tunnel is created with the Brave app.

@deeppandya deeppandya self-assigned this Dec 13, 2023
@igornazarov1991
Copy link

@deeppandya , is "kill switch" available on iOS platform as well?

@deeppandya
Copy link

@deeppandya , is "kill switch" available on iOS platform as well?

@igornazarov1991 it's not available on IOS AFAIK

@timchilds
Copy link

This will be done alongside adding option to Always on VPN in settings #37013

@timchilds timchilds changed the title Add an explicit "Block connections without VPN" setting to VPN (VPN kill switch) [Android] Add an explicit "Block connections without VPN" setting to VPN (VPN kill switch) Apr 9, 2024
@deeppandya deeppandya added priority/P2 A bad problem. We might uplift this to the next planned release. and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Apr 10, 2024
Android General automation moved this from P3 to Done/Closed May 1, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 1, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Jun 13, 2024

Verification PASSED on Vivo X70 Pro version 12 running Bravemonoarm64.apk_1.67.113

@GeetaSarvadnya GeetaSarvadnya added QA/In-Progress Indicates that QA is currently in progress for that particular issue QA Pass - Android ARM and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature/vpn feature-request OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. privacy/discussed Discussed in privacy confab privacy/feature User-facing privacy- & security-focused feature work. QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
Android General
  
Done/Closed
VPN
Untriaged backlog
Development

Successfully merging a pull request may close this issue.

9 participants