-
Notifications
You must be signed in to change notification settings - Fork 833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vpn always on & kill switch android #23293
Conversation
2. Find Brave VPN and tap on the settings icon to the right. | ||
</message> | ||
<message name="IDS_KILL_SWITCH_TUTORIAL_TEXT_3" desc="Vpn kill swicth tutorial text"> | ||
3. Toggle <ph name="ALWAYS_ON_TUTORIAL_START"><always_on_tutorial></ph>Always-on VPN<ph name="ALWAYS_ON_TUTORIAL_END"></always_on_tutorial></ph> to enable it.\n4. Toggle <ph name="ALWAYS_ON_TUTORIAL_2_START"><always_on_tutorial_2></ph>Block connections without VPN<ph name="ALWAYS_ON_TUTORIAL_2_END"></always_on_tutorial_2></ph> to enable the kill switch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would do 1, 2, 3, 4 rather or together or 3 and 4 as separate strings as 1, 2.
android:text="@string/kill_switch_text" | ||
android:gravity="center_horizontal"/> | ||
</LinearLayout> | ||
</ScrollView> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: empty line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
++
Add roboto flex font
Update text change with license header
3b83bd5
to
95a1b6b
Compare
[puLL-Merge] - brave/brave-core@23293 DescriptionThis PR adds a new "Always-on VPN & Kill switch" feature to the Brave VPN settings on Android. It includes a tutorial screen explaining how to enable always-on VPN and the kill switch in the Android system settings. ChangesChanges
Security HotspotsNone identified. The changes are limited to the Brave VPN UI and do not seem to introduce any new security risks. The always-on VPN and kill switch capabilities leverage the existing Android system settings securely. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strings
++
Resolves brave/brave-browser#37013
Resolves brave/brave-browser#23193
Submitter Checklist:
QA/Yes
orQA/No
;release-notes/include
orrelease-notes/exclude
;OS/...
) to the associated issuenpm run test -- brave_browser_tests
,npm run test -- brave_unit_tests
wikinpm run presubmit
wiki,npm run gn_check
,npm run tslint
git rebase master
(if needed)Reviewer Checklist:
gn
After-merge Checklist:
changes has landed on
Test Plan: