Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add spacing between title and body and increase contrast for ad description text #23931

Closed
srirambv opened this issue Jul 8, 2022 · 4 comments · Fixed by brave/brave-core#19121
Closed

Add spacing between title and body and increase contrast for ad description text #23931

srirambv opened this issue Jul 8, 2022 · 4 comments · Fixed by brave/brave-core#19121
Assignees
@aseren
Labels
design A design change, especially one which needs input from the design team enhancement feature/ads OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android 8+ QA/Yes release-notes/exclude
Projects
Ads
Milestone
1.58.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Jul 8, 2022

Description

Add spacing between title and body and increase contrast for ad description text

Steps to reproduce

  1. View ads on Android
  2. Check the ads in collapsed view vs expanded view

Actual result

Expected result

More padding between title and body and more contrast on the description text

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

All

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @aseren @tmancey @jenn-rhim
@srirambv srirambv added QA/Yes release-notes/include feature/ads OS/Android Fixes related to Android browser functionality labels Jul 8, 2022
@tmancey tmancey added this to New issues in Ads via automation Jul 8, 2022
@tmancey tmancey moved this from New issues to Icebox in Ads Jul 11, 2022
@meeddhhaa
Copy link

Hey guys @tmancey @srirambv could I work on this one?

@tmancey tmancey moved this from Icebox to Suggested Backlog in Ads Apr 13, 2023
@tmancey tmancey moved this from Suggested Backlog to Backlog in Ads Apr 13, 2023
@tmancey tmancey moved this from Backlog to Suggested Backlog in Ads Apr 13, 2023
@tmancey tmancey moved this from Suggested Backlog to Icebox in Ads Apr 13, 2023
@tmancey tmancey added design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. blocked labels Apr 13, 2023
@tmancey tmancey moved this from Icebox to Blocked in Ads Apr 13, 2023
@jenn-rhim
Copy link

Text color: Light/Divicer/Strong in our Design System
Spacing: default 22px

Will see if we need to adjust ^

cc @aguscruiz

@aguscruiz
Copy link

These are android native notifications right?
I've added mockups based on Android's guidelines here, we can use them as reference in terms of sizing, spacing, etc.
They're supposed to look as native as possible

https://www.figma.com/file/loFHVWcBAuuApFsH9V3T5I/%F0%9F%A4%96-Android?type=design&node-id=2169%3A15476&t=vjXqTFW1IInaFa4H-1

@tmancey tmancey removed design/needs-mock-up needs-mockup A feature which needs design mockup to be implemented. blocked labels Jun 14, 2023
@tmancey tmancey moved this from Blocked to Up Next in Ads Jun 14, 2023
@tmancey tmancey added the design A design change, especially one which needs input from the design team label Jun 14, 2023
@tmancey tmancey moved this from Up Next to Backlog in Ads Jun 14, 2023
@aseren aseren mentioned this issue Jun 27, 2023
Closed
@aseren aseren moved this from Backlog to In progress in Ads Jun 27, 2023
@aseren aseren self-assigned this Jun 27, 2023
@aseren aseren mentioned this issue Jun 30, 2023
Merged
25 tasks
@aseren aseren moved this from In progress to Review in Ads Jun 30, 2023
Ads automation moved this from Review to Done Jul 5, 2023
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jul 5, 2023
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Aug 29, 2023
@hffvld
Copy link
Contributor

hffvld commented Aug 29, 2023 •
edited

Verified on Pixel 2 XL, Pixel 6 and Pixel 7 using version(s):

Device/OS: 
- Pixel 2 XL [taimen-user  8.1.0 OPM2.171026.006.H1 release-keys]
- Pixel 6 [oriole-user 13 TQ3A.230805.001 release-keys]
- Pixel 7 [panther_beta-user 14 UPB5.230623.006 release-keys]
Brave build: 1.58.106 
Chromium: 116.0.5845.114 (Official Build) beta (64-bit) 
Revision: 601f5c9afccc48f581021ae0e0ee6c85b58821d2

STEPS:

  1. Launch Brave
  2. Enable Rewards to trigger Brave ads
  3. Wait until ad notifications are received
  4. Pull the notification drawer > Verify

ACTUAL RESULTS:

  • Verified that spacing between title and body increased compared to the previous version
  • Verified that contrast for as description text increased as well

Android 8

1 2
1 2

Android 13

1 2 3 4
1 2 3 4
1 2 3 4

Android 14

1 2 3 4
1 2 3 4

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android 8+ and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Aug 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aseren aseren

Labels
design A design change, especially one which needs input from the design team enhancement feature/ads OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android 8+ QA/Yes release-notes/exclude
Projects
Ads
  
Done
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Fix Brave Ads notification for Android brave/brave-core
8 participants
@tmancey @jenn-rhim @aguscruiz @srirambv @brave-builds @meeddhhaa @aseren @hffvld