Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Brave Ads notification for Android #19121

Merged
merged 1 commit into from
Jul 5, 2023
Merged

Fix Brave Ads notification for Android #19121

merged 1 commit into from
Jul 5, 2023

Conversation

aseren
Copy link
Collaborator

@aseren aseren commented Jun 30, 2023

The PR changes spacing between a title and a body for a Brave Ads notification to be the same as for system notifications.

Brave Ads notification for Android 12:

Brave Ads notification for Android 10:

Resolves brave/brave-browser#23931

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run lint, npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • Trigger a Brave Ads notification
  • Make sure that spacing between title and body is correct

Copy link
Contributor

@deeppandya deeppandya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@tmancey tmancey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aseren aseren force-pushed the issues/23931 branch 3 times, most recently from 80584a8 to d3e019c Compare July 4, 2023 18:41
@aseren aseren enabled auto-merge July 4, 2023 21:39
@aseren aseren merged commit c89477c into master Jul 5, 2023
13 checks passed
@aseren aseren deleted the issues/23931 branch July 5, 2023 17:10
@github-actions github-actions bot added this to the 1.55.x - Nightly milestone Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants