Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement create solana account option in buysendswap #24463

Closed
Pavneet-Sing opened this issue Aug 5, 2022 · 1 comment · Fixed by brave/brave-core#14497
Closed

Implement create solana account option in buysendswap #24463

Pavneet-Sing opened this issue Aug 5, 2022 · 1 comment · Fixed by brave/brave-core#14497
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.44.x - Release

Comments

@Pavneet-Sing
Copy link

Description

Show auto solana account create dialog in buysendswap for send when there is no solana account

Steps to reproduce

  1. Create wallet
  2. click send
  3. select solana account, should ask to create solana account
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/solana labels Aug 5, 2022
@Pavneet-Sing Pavneet-Sing mentioned this issue Aug 5, 2022
Merged
25 tasks
@brave-builds brave-builds added this to the 1.44.x - Nightly milestone Aug 8, 2022
@srirambv
Copy link
Contributor

Verification passed on Oppo Reno 5 with Android 12 running 1.44.79 x64 Beta build

  • Verified steps from brave/brave-core#14497
  • Verified able to create Solana account from Send screen
  • Verified able to submit a send transaction as soon as the account is created from Send screen
  • Encountered #25373
24463.mp4

@Pavneet-Sing Pavneet-Sing self-assigned this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet/solana feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.44.x - Release
Development

Successfully merging a pull request may close this issue.

feat(wallet): show default network tx brave/brave-core
4 participants
@kjozwiak @Pavneet-Sing @srirambv @brave-builds