Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selecting No for creating Solana Account doesn't set the network back to Ethereum in Send screen #25373

Closed
srirambv opened this issue Sep 13, 2022 · 1 comment · Fixed by brave/brave-core#15118
Assignees
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Selecting No for creating Solana Account doesn't set the network back to Ethereum in Send screen

Steps to reproduce

  1. Clean profile & Create wallet
  2. Select Send from BuySendSwap button
  3. Select Solana from network dropdown
  4. Select No to cancel account creation
  5. Network remains as Solana but token/address is still set to Ethereum

Actual result

Create.Solana.Account.mp4

Expected result

Reset network back to Ethereum or selected EVM network if user cancels to create Solana Account

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 12

Brave version

1.44.79

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @Pavneet-Sing

@srirambv srirambv added bug QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Sep 13, 2022
@srirambv srirambv added this to Backlog in Android General via automation Sep 13, 2022
@Pavneet-Sing Pavneet-Sing moved this from Backlog to In Progress in Android General Sep 16, 2022
Android General automation moved this from In Progress to Done/Closed Sep 19, 2022
@brave-builds brave-builds added this to the 1.45.x - Nightly milestone Sep 19, 2022
@Pavneet-Sing Pavneet-Sing self-assigned this Sep 19, 2022
@srirambv
Copy link
Contributor Author

Verification passed on the following devices running 1.45.88 x64 Beta build

  • Verified steps from issue description & brave/brave-core#15118
  • Verified selecting No doesn't set network to Solana
  • Verified able to create a Solana account successfully on upgrade
Oppo Reno 5 (Android 12) Samsung Tab A (Android 10)
25373-ARM.mp4
25373-Tab.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/exclude
Projects
Android General
  
Done/Closed
Archived in project
Development

Successfully merging a pull request may close this issue.

3 participants