Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed folders re-synced only on toolbar (no folders structure), when two devices are still in sync #2458

Closed
GeetaSarvadnya opened this issue Dec 11, 2018 · 3 comments

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 11, 2018

Description

Removed folders are not re-synced properly, when two devices are still in sync

Devices

Device 1: Windows 10 bc -0.58.11 (Sync creator)
Device 2: VM - Windows 8 bc- 0.58.11

Steps to Reproduce

  1. Sync two devices Windows-10 and VM Windows-8
  2. Open the secret sync code on Windows 10 and copy it
  3. Paste the secrete code on VM-Windows 8
  4. Make sure two devices are in sync
  5. Import 5k bookmarks on Windows 10
  6. Make sure 5k boomarks are synced in VM Window 8 (Folder structure is same on both devices)
  7. Delete the bookmark root folder from Windows 10
  8. Verify that, after few minutes, the bookmarks again started re-syncing in Windows 10 (As sync chain is still established)
  9. Verify the folder structure in Win 10 after re-sync

Actual result:

All the re-synced bookmarks are displayed on the bookmak toolbar. There are no folders under bookmarks manager.
image

Expected result:

Folder structure should be maintained after re-sync

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.58.11 Chromium: 71.0.3578.80 (Official Build) beta (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Windows

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? NA

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional Information

@brave/legacy_qa

@GeetaSarvadnya GeetaSarvadnya added this to the 0.58.x - Beta milestone Dec 11, 2018
@GeetaSarvadnya GeetaSarvadnya changed the title Removed folders are not re-syncing properly, when two devices are in sync already. Removed folders are not re-syncing properly, when two devices are in are still in sync Dec 11, 2018
@GeetaSarvadnya GeetaSarvadnya changed the title Removed folders are not re-syncing properly, when two devices are in are still in sync Removed folders are not re-syncing properly, when two devices are still in sync Dec 11, 2018
@rebron rebron added this to Untriaged backlog in Sync Dec 11, 2018
@GeetaSarvadnya GeetaSarvadnya changed the title Removed folders are not re-syncing properly, when two devices are still in sync Removed folders are not re-synced properly, when two devices are still in sync Dec 12, 2018
@rebron rebron modified the milestones: 0.58.x - Release, 1.x Backlog Dec 12, 2018
@rebron
Copy link
Collaborator

rebron commented Dec 12, 2018

@GeetaSarvadnya Fix for #2133 just landed and want to see if that fix takes care of this issue when we get a new RC build for 58.x

@darkdh
Copy link
Member

darkdh commented Dec 12, 2018

it should be fixed in brave/brave-core#982

@darkdh darkdh closed this as completed Dec 12, 2018
Sync automation moved this from Untriaged backlog to Completed Dec 12, 2018
@bbondy bbondy modified the milestones: 1.x Backlog, 0.58.x - Release Dec 20, 2018
@GeetaSarvadnya GeetaSarvadnya changed the title Removed folders are not re-synced properly, when two devices are still in sync Removed folders re-synced only on toolbar (no folders structure), when two devices are still in sync Dec 25, 2018
@GeetaSarvadnya
Copy link
Author

GeetaSarvadnya commented Dec 25, 2018

@darkdh #2458 verification is blocked due to #2738

Verified the STR mentioned in the issue.
Step 8 Failed, the removed folders not being re-syned on device A, even after 10 - 15 mins. - Logged new issue #2738

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows 10

Verified with

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Verification passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

Encountered #2738

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants