Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed folders doesn't re-sync even though device are in sync (follow up of #2458) #2738

Closed
GeetaSarvadnya opened this issue Dec 25, 2018 · 5 comments
Labels

Comments

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 25, 2018

Description

Found while testing #2458
Deleted folders doesn't re-sync even though device are in sync (follow up of #2458)

Steps to Reproduce

  1. Setup sync between Device A and B
  2. Import 5k bookmarks in device A
  3. Make sure 5k bookmarks are synced in device B
  4. Remove 5k bookmarks root folder from device A

Actual result:

Deleted bookmarks doesn't re-sync on device A . (Waited for almost 15 mins)

Console log errors:

image

Expected result:

Deleted bookmarks should re-sync in device A<->B, when two devices are still in sync chain.

Reproduces how often:

Always

Brave version (brave://version info)

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows 10

Reproducible on current release: na

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? na
  • Is the issue reproducible on the latest version of Chrome? na

Additional Information

@brave/legacy_qa

@AlexeyBarabash
Copy link
Contributor

Errors in the attached screenshot should be fixed with issue #2579, PR brave/brave-core#1179 .

@AlexeyBarabash
Copy link
Contributor

Could not reproduce on current master Version 0.61.0 Chromium: 72.0.3626.28.
Could reproduce particularly on Version 0.59.12 Chromium: 72.0.3626.17, the root folder had not been deleted on DeviceB for a long time, but finally it gone.

I think, this is related with PR brave/sync#265 from @darkdh which made speedup for interaction with AWS.

@btlechowski
Copy link

Reproduced when testing #2458 on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Linux

@srirambv
Copy link
Contributor

@brave/legacy_qa Needs to be retested once new beta build is available.

@rebron rebron added the priority/P4 Planned work. We expect to get to it "soon". label Jan 16, 2019
@rebron
Copy link
Collaborator

rebron commented Jan 16, 2019

cc: @bradleyrichter to clarify expected behavior. Let's reduce to user case to 1 bookmark.

@rebron rebron removed this from the 1.x Backlog milestone Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Completed
Development

No branches or pull requests

7 participants