Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

re-enabling wifi does not show sync QR code or words #2537

Closed
LaurenWags opened this issue Dec 13, 2018 · 1 comment · Fixed by brave/brave-core#1109
Closed

re-enabling wifi does not show sync QR code or words #2537

LaurenWags opened this issue Dec 13, 2018 · 1 comment · Fixed by brave/brave-core#1109

Comments

@LaurenWags
Copy link
Member

LaurenWags commented Dec 13, 2018

Description

Similar to #2533 but this case has consistently reproducible steps.

If you have wifi off when you first visit brave://sync page and attempt to create a sync chain, when you re-enable wifi the QR code and words will not be displayed. However, a refresh of the page resolves this.

Steps to Reproduce

  1. Clean install 0.58.12
  2. Disable wifi
  3. Hamburger menu > Brave Sync
  4. Click on Start a new sync chain
  5. Get message about internet connection.
  6. Close message.
  7. Reenable wifi.
  8. Click on Start a new sync chain again.
  9. Click on Phone/Tablet or Computer.

Actual result:

No QR code or words are displayed

screen shot 2018-12-13 at 9 01 02 am

screen shot 2018-12-13 at 9 01 10 am

Expected result:

QR code or words should be displayed.

Reproduces how often:

easily

Brave version (brave://version info)

Brave 0.58.12 Chromium: 71.0.3578.80 (Official Build) (64-bit)
Revision 2ac50e7249fbd55e6f517a28131605c9fb9fe897-refs/branch-heads/3578@{#860}
OS Mac OS X

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds? yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields? n/a
  • Is the issue reproducible on the latest version of Chrome? n/a

Additional Information

Similar to #2533

cc @brave/legacy_qa for verification on other platforms

@LaurenWags LaurenWags added this to the 1.x Backlog milestone Dec 13, 2018
@cezaraugusto cezaraugusto self-assigned this Dec 13, 2018
@darkdh darkdh added this to Untriaged backlog in Sync Dec 13, 2018
@darkdh darkdh self-assigned this Dec 16, 2018
@darkdh darkdh moved this from Untriaged backlog to Inprogress in Sync Dec 16, 2018
Sync automation moved this from Inprogress to Completed Dec 17, 2018
@kjozwiak kjozwiak modified the milestones: 1.x Backlog, 0.58.x - Release Dec 17, 2018
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 25, 2018

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Windows
  • Verified the STR mentioned in the issue

Verification passed on

Brave 0.59.12 Chromium: 72.0.3626.17 (Official Build) beta (64-bit)
Revision 08d2140079f8db14c9eb885a803d231b1a30e817-refs/branch-heads/3626@{#315}
OS Linux

  • Verified the STR mentioned in the issue

Verified passed on

Brave 0.59.14 Chromium: 72.0.3626.28 (Official Build) beta(64-bit)
Revision 997b1040b63bac324e815797ba52be0cd8f616ed-refs/branch-heads/3626@{#461}
OS Mac OS X

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment